groupBy return either a Map or an OrderedMap: make the type more precise #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeniau
force-pushed
the
ts-better-groupBy-type
branch
from
c15f5bc
to
3cc13d2
Compare
jdeniau
commented
Jan 9, 2023
type-definitions/immutable.d.ts
Outdated
| @@ -4600,7 +4600,7 @@ declare namespace Immutable { | |||
| groupBy<G>( | |||
| grouper: (value: V, key: K, iter: this) => G, | |||
| context?: unknown | |||
| ): /*Map*/ Seq.Keyed<G, /*this*/ Collection<K, V>>; | |||
| ): Map<G, /*this*/ Collection<K, V>>; | |||
There was a problem hiding this comment.
We might want to override each class to be even more precise as
List<number>().groupBy(v => v); // is a Map<G, List<K, V>>
Set<number>().groupBy(v => v); // is an OrderedMap<G, Set<V, V>>
// etc.There was a problem hiding this comment.
I tried to implement this, but got a lot of error:
Type instantiation is excessively deep and possibly infinite.
I did not manage to solve this, so I merge this as the current implementation is nearly right: we lose the fact that the Map is, sometimes, ordered, but we still gain all Map API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.