Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partition to flow spec #1920

Merged
merged 2 commits into from Jan 2, 2023
Merged

Add partition to flow spec #1920

merged 2 commits into from Jan 2, 2023

Conversation

Dagur
Copy link
Contributor

@Dagur Dagur commented Dec 23, 2022

No description provided.

@jdeniau
Copy link
Member

jdeniau commented Dec 23, 2022

Cannot use type without exactly 1 type argument. [nonpolymorphic-type-app]

It seems that tuples are handled this way in flow:

[this, this]

and not

Array<this, this>

source

Or it might be an issue with an old version of flow. If you want, you can upgrade the flow version to a most recent one

@Dagur
Copy link
Contributor Author

Dagur commented Dec 23, 2022

Yeah this was completely wrong, I'm not sure why it wasn't flagged.
I'm fixing this now

@Dagur
Copy link
Contributor Author

Dagur commented Dec 29, 2022

Should be alright now btw

@jdeniau jdeniau merged commit 03d8b39 into immutable-js:main Jan 2, 2023
@jdeniau jdeniau linked an issue Jan 2, 2023 that may be closed by this pull request
@jdeniau
Copy link
Member

jdeniau commented Jan 2, 2023

Thanks @Dagur . Released in 4.2.2

@Dagur
Copy link
Contributor Author

Dagur commented Jan 6, 2023

Thank you too.
One question though, the latest version on npm is still 4.2.1. Is that just them being slow?

@jdeniau
Copy link
Member

jdeniau commented Jan 6, 2023

@Dagur thanks for notifying me, the released process did fail. The 4.2.2 is now available on npmjs

@Dagur
Copy link
Contributor Author

Dagur commented Jan 6, 2023

awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.2.0: partition missing in flow
2 participants