Faster and implementation of some (#1944)

immutable-js · Jul 10, 2023 · ad5aeb4 · ad5aeb4
1 parent 6e0720c
commit ad5aeb4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/perf/List.js b/perf/List.js
@@ -100,4 +100,14 @@ describe('List', function () {
       list = list.asImmutable();
     });
   });
+
+  describe('some', function () {
+    it('100 000 items ', () => {
+      const list = Immutable.List();
+      for (let i = 0; i < 100000; i++) {
+        list.push(i);
+      }
+      list.some(item => item === 50000);
+    });
+  });
 });
diff --git a/src/CollectionImpl.js b/src/CollectionImpl.js
@@ -266,7 +266,15 @@ mixin(Collection, {
   },
 
   some(predicate, context) {
-    return !this.every(not(predicate), context);
+    assertNotInfinite(this.size);
+    let returnValue = false;
+    this.__iterate((v, k, c) => {
+      if (predicate.call(context, v, k, c)) {
+        returnValue = true;
+        return false;
+      }
+    });
+    return returnValue;
   },
 
   sort(comparator) {