Timezone Plugin #974
Merged
Timezone Plugin #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #974 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 169 170 +1
Lines 1435 1476 +41
Branches 307 311 +4
=========================================
+ Hits 1435 1476 +41
Continue to review full report at Codecov.
|
|
Many thanks |
GerardSmit
reviewed
Jul 30, 2020
| describe('Convert', () => { | ||
| it('convert to target time', () => { | ||
| const losAngeles = dayjs('2014-06-01T12:00:00Z').tz('America/Los_Angeles') | ||
| const MlosAngeles = dayjs('2014-06-01T12:00:00Z').tz('America/Los_Angeles') |
There was a problem hiding this comment.
There seems to be a typo here, shouldn't this use moment.tz instead of dayjs?
iamkun
pushed a commit
that referenced
this pull request
Aug 4, 2020
## [1.8.32](v1.8.31...v1.8.32) (2020-08-04) ### Bug Fixes * Add Experimental Timezone Plugin ([#974](#974)) ([e69caba](e69caba)) * fix parse date string error e.g. '2020/9/30' ([#980](#980)) ([231790d](231790d)), closes [#979](#979) * update monthDiff function to get more accurate results ([19e8a7f](19e8a7f)) * Update UTC plugin to support keepLocalTime ([#973](#973)) ([9f488e5](9f488e5))
|
🎉 This PR is included in version 1.8.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.32](iamkun/dayjs@v1.8.31...v1.8.32) (2020-08-04) ### Bug Fixes * Add Experimental Timezone Plugin ([#974](iamkun/dayjs#974)) ([e69caba](iamkun/dayjs@e69caba)) * fix parse date string error e.g. '2020/9/30' ([#980](iamkun/dayjs#980)) ([231790d](iamkun/dayjs@231790d)), closes [#979](iamkun/dayjs#979) * update monthDiff function to get more accurate results ([19e8a7f](iamkun/dayjs@19e8a7f)) * Update UTC plugin to support keepLocalTime ([#973](iamkun/dayjs#973)) ([9f488e5](iamkun/dayjs@9f488e5))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.32](iamkun/dayjs@v1.8.31...v1.8.32) (2020-08-04) ### Bug Fixes * Add Experimental Timezone Plugin ([#974](iamkun/dayjs#974)) ([e69caba](iamkun/dayjs@e69caba)) * fix parse date string error e.g. '2020/9/30' ([#980](iamkun/dayjs#980)) ([231790d](iamkun/dayjs@231790d)), closes [#979](iamkun/dayjs#979) * update monthDiff function to get more accurate results ([19e8a7f](iamkun/dayjs@19e8a7f)) * Update UTC plugin to support keepLocalTime ([#973](iamkun/dayjs#973)) ([9f488e5](iamkun/dayjs@9f488e5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timezon plugin
Thanks luxon and Intl.DateTimeFormat()
Update: https://day.js.org/docs/en/timezone/timezone