Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update UTC plugin to support keepLocalTime #973

Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix: update UTC plugin to support keepLocalTime #973

merged 2 commits into from
Jul 29, 2020

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Jul 29, 2020

fix #935

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #973 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #973   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          169       169           
  Lines         1429      1515   +86     
  Branches       305       337   +32     
=========================================
+ Hits          1429      1515   +86     
Impacted Files Coverage Δ
src/plugin/utc/index.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cfa84...3bab986. Read the comment docs.

@iamkun iamkun merged commit 9f488e5 into dev Jul 29, 2020
@iamkun iamkun deleted the fix/utc branch July 30, 2020 10:41
iamkun pushed a commit that referenced this pull request Aug 4, 2020
## [1.8.32](v1.8.31...v1.8.32) (2020-08-04)

### Bug Fixes

* Add Experimental Timezone Plugin ([#974](#974)) ([e69caba](e69caba))
* fix parse date string error e.g. '2020/9/30' ([#980](#980)) ([231790d](231790d)), closes [#979](#979)
* update monthDiff function to get more accurate results ([19e8a7f](19e8a7f))
* Update UTC plugin to support keepLocalTime ([#973](#973)) ([9f488e5](9f488e5))
@iamkun
Copy link
Owner Author

iamkun commented Aug 4, 2020

🎉 This PR is included in version 1.8.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Aug 4, 2020
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.32](iamkun/dayjs@v1.8.31...v1.8.32) (2020-08-04)

### Bug Fixes

* Add Experimental Timezone Plugin ([#974](iamkun/dayjs#974)) ([e69caba](iamkun/dayjs@e69caba))
* fix parse date string error e.g. '2020/9/30' ([#980](iamkun/dayjs#980)) ([231790d](iamkun/dayjs@231790d)), closes [#979](iamkun/dayjs#979)
* update monthDiff function to get more accurate results ([19e8a7f](iamkun/dayjs@19e8a7f))
* Update UTC plugin to support keepLocalTime ([#973](iamkun/dayjs#973)) ([9f488e5](iamkun/dayjs@9f488e5))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.32](iamkun/dayjs@v1.8.31...v1.8.32) (2020-08-04)

### Bug Fixes

* Add Experimental Timezone Plugin ([#974](iamkun/dayjs#974)) ([e69caba](iamkun/dayjs@e69caba))
* fix parse date string error e.g. '2020/9/30' ([#980](iamkun/dayjs#980)) ([231790d](iamkun/dayjs@231790d)), closes [#979](iamkun/dayjs#979)
* update monthDiff function to get more accurate results ([19e8a7f](iamkun/dayjs@19e8a7f))
* Update UTC plugin to support keepLocalTime ([#973](iamkun/dayjs#973)) ([9f488e5](iamkun/dayjs@9f488e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to keep the existing time of day when using utcOffset() for creating moments in time
1 participant