Fix negative duration #1317
Merged
Fix negative duration #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 176 176
Lines 1709 1737 +28
Branches 391 394 +3
=========================================
+ Hits 1709 1737 +28
Continue to review full report at Codecov.
|
kamontat
added a commit
to kamontat/countdown
that referenced
this pull request
Jan 6, 2021
iamkun
reviewed
Jan 9, 2021
iamkun
reviewed
Jan 17, 2021
|
Cool, thanks |
iamkun
pushed a commit
that referenced
this pull request
Jan 22, 2021
## [1.10.4](v1.10.3...v1.10.4) (2021-01-22) ### Bug Fixes * Correct handling negative duration ([#1317](#1317)) ([3f5c085](3f5c085)) * Improve `Duration` types ([#1338](#1338)) ([4aca4b1](4aca4b1)) * parse a string for MMM month format with underscore delimiter ([#1349](#1349)) ([82ef9a3](82ef9a3)) * Update Bengali [bn] locale ([#1329](#1329)) ([02d96ec](02d96ec)) * update locale Portuguese [pt] yearStart ([#1345](#1345)) ([5c785d5](5c785d5)) * update Polish [pl] locale yearStart ([#1348](#1348)) ([e93e6b8](e93e6b8)) * Update Slovenian [sl] relativeTime locale ([#1333](#1333)) ([fe5f1d0](fe5f1d0))
|
🎉 This PR is included in version 1.10.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 16, 2021
johannpayer
reviewed
Mar 29, 2021
src/plugin/duration/index.js
Outdated
| @@ -25,6 +25,7 @@ const wrapper = (input, instance, unit) => | |||
| new Duration(input, unit, instance.$l) // eslint-disable-line no-use-before-define | |||
|
|
|||
| const prettyUnit = unit => `${$u.p(unit)}s` | |||
| const roundNumber = number => number < 0 ? Math.ceil(number) : Math.floor(number) | |||
There was a problem hiding this comment.
This could be replaced with Math.trunc(number), which is shorter.
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.4](iamkun/dayjs@v1.10.3...v1.10.4) (2021-01-22) ### Bug Fixes * Correct handling negative duration ([#1317](iamkun/dayjs#1317)) ([3f5c085](iamkun/dayjs@3f5c085)) * Improve `Duration` types ([#1338](iamkun/dayjs#1338)) ([4aca4b1](iamkun/dayjs@4aca4b1)) * parse a string for MMM month format with underscore delimiter ([#1349](iamkun/dayjs#1349)) ([82ef9a3](iamkun/dayjs@82ef9a3)) * Update Bengali [bn] locale ([#1329](iamkun/dayjs#1329)) ([02d96ec](iamkun/dayjs@02d96ec)) * update locale Portuguese [pt] yearStart ([#1345](iamkun/dayjs#1345)) ([5c785d5](iamkun/dayjs@5c785d5)) * update Polish [pl] locale yearStart ([#1348](iamkun/dayjs#1348)) ([e93e6b8](iamkun/dayjs@e93e6b8)) * Update Slovenian [sl] relativeTime locale ([#1333](iamkun/dayjs#1333)) ([fe5f1d0](iamkun/dayjs@fe5f1d0))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.4](iamkun/dayjs@v1.10.3...v1.10.4) (2021-01-22) ### Bug Fixes * Correct handling negative duration ([#1317](iamkun/dayjs#1317)) ([3f5c085](iamkun/dayjs@3f5c085)) * Improve `Duration` types ([#1338](iamkun/dayjs#1338)) ([4aca4b1](iamkun/dayjs@4aca4b1)) * parse a string for MMM month format with underscore delimiter ([#1349](iamkun/dayjs#1349)) ([82ef9a3](iamkun/dayjs@82ef9a3)) * Update Bengali [bn] locale ([#1329](iamkun/dayjs#1329)) ([02d96ec](iamkun/dayjs@02d96ec)) * update locale Portuguese [pt] yearStart ([#1345](iamkun/dayjs#1345)) ([5c785d5](iamkun/dayjs@5c785d5)) * update Polish [pl] locale yearStart ([#1348](iamkun/dayjs#1348)) ([e93e6b8](iamkun/dayjs@e93e6b8)) * Update Slovenian [sl] relativeTime locale ([#1333](iamkun/dayjs#1333)) ([fe5f1d0](iamkun/dayjs@fe5f1d0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I create Duration with negative number, the default value of each unit is -1 since you round everything down (Math.floor).
Solution
I add if case when number is negative it should run Math.ceil() instead.
Example
For positive number
For negative number (current)
For negative number (expected)