Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use data-uri for og:image #5053

Merged
merged 1 commit into from Sep 7, 2022
Merged

Don't use data-uri for og:image #5053

merged 1 commit into from Sep 7, 2022

Conversation

KentarouTakeda
Copy link
Contributor

What does it do?

fix #5052

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

How to test

git clone -b dont-use-dataUri-for-ogImage https://github.com/ktakeda-forks/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 98.339% when pulling a901694 on ktakeda-forks:dont-use-dataUri-for-ogImage into 6deeb8d on hexojs:master.

@KentarouTakeda
Copy link
Contributor Author

Some CI processes seem to be failing, but I don't know why.
(It seems to be an authentication problem, so the pull request itself may not be the cause)

Please tell me if there is anything I can do.

SukkaW
SukkaW approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching it!

@SukkaW SukkaW merged commit 06a8ebb into hexojs:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data URI scheme for og:image
3 participants
@KentarouTakeda @coveralls @SukkaW