Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag/code): add language_attr option (hexojs/hexo-util#278) #5017

Merged
merged 1 commit into from Sep 6, 2022
Merged

feat(tag/code): add language_attr option (hexojs/hexo-util#278) #5017

merged 1 commit into from Sep 6, 2022

Conversation

renbaoshuo
Copy link
Member

What does it do?

Add an option called language_attr.

Screenshots

None.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b highlight/language-attr https://github.com/renbaoshuo/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Jul 16, 2022 •
edited

Coverage Status

Coverage increased (+0.001%) to 98.036% when pulling f935f18 on renbaoshuo:highlight/language-attr into b48f095 on hexojs:master.

@yoshinorin
Copy link
Member

@renbaoshuo
Does we need release a new version of hexo-util before merge this PR?

@yoshinorin
Copy link
Member

Pending hexojs/hexo-util#279

@yoshinorin yoshinorin mentioned this pull request Aug 8, 2022
Merged
2 tasks
@renbaoshuo renbaoshuo marked this pull request as draft August 19, 2022 07:24
@renbaoshuo renbaoshuo marked this pull request as ready for review August 19, 2022 14:39
yoshinorin
yoshinorin approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@yoshinorin yoshinorin mentioned this pull request Aug 30, 2022
Merged
2 tasks
@renbaoshuo renbaoshuo merged commit 6deeb8d into hexojs:master Sep 6, 2022
@renbaoshuo renbaoshuo deleted the highlight/language-attr branch September 6, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renbaoshuo @coveralls @yoshinorin