Fix js-yaml tags for v4.0.0+ #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
force-pushed
the
patch-1
branch
from
03723ab
to
7808bec
Compare
Repair backwards compatibility https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md with a bunch of plugins that use these yaml tags. e.g.: https://github.com/lavas-project/hexo-pwa#options uses these yaml tags in the routes `!!js/regexp`
marcofranssen
force-pushed
the
patch-1
branch
from
7808bec
to
2015306
Compare
How to testgit clone -b patch-1 https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
|
cool |
yoshinorin
approved these changes
Jan 19, 2022
|
@marcofranssen |
|
@yoshinorin a pleasure. When can we expect a patch for the 6.x and 5.4.x versions? |
yoshinorin
pushed a commit
to yoshinorin/hexo
that referenced
this pull request
Jan 22, 2022
Repair backwards compatibility https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md with a bunch of plugins that use these yaml tags. e.g.: https://github.com/lavas-project/hexo-pwa#options uses these yaml tags in the routes `!!js/regexp`
2 tasks
|
@marcofranssen |
yoshinorin
added a commit
that referenced
this pull request
Jan 22, 2022
Repair backwards compatibility https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md with a bunch of plugins that use these yaml tags. e.g.: https://github.com/lavas-project/hexo-pwa#options uses these yaml tags in the routes `!!js/regexp` Co-authored-by: Marco Franssen <marco.franssen@gmail.com>
|
I just published Regarding to |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair backwards compatibility https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md
with a bunch of plugins that use these yaml tags.
e.g.: https://github.com/lavas-project/hexo-pwa#options uses these yaml tags in the routes
!!js/regexpWhat does it do?
Fixes backwards compatibility for some plugins that make use of js-yaml tags.
This broke since the hexo 5.4.0 release that bumps
js-yamlto v4.0.0.See:
https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md#400---2021-01-03
and
https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md
for details.