Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line threshold option for codeblocks #4821

Merged
merged 1 commit into from Jan 22, 2022
Merged

Add line threshold option for codeblocks #4821

merged 1 commit into from Jan 22, 2022

Conversation

dbelokon
Copy link
Contributor

Addresses #4516

What does it do?

Accepts an optional threshold to only show line numbers as long as the numbers of lines of the code block exceed such threshold.

How to test

git clone -b issue-4516 https://github.com/dbelokon/hexo.git
cd hexo
npm install
npm test

Screenshots

I don't have any screenshots, yet.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@stevenjoezhang stevenjoezhang linked an issue Nov 22, 2021 that may be closed by this pull request
Only show line number when number of lines of code greater than a threshold #4516
Closed
2 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.125% when pulling 85dbb32 on dbelokon:issue-4516 into 902cd70 on hexojs:master.

@SukkaW SukkaW merged commit f12a8db into hexojs:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only show line number when number of lines of code greater than a threshold
3 participants
@dbelokon @coveralls @SukkaW