Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github(pull_request_template): remove How to test section #4576

Merged
merged 3 commits into from Jan 16, 2022
Merged

github(pull_request_template): remove How to test section #4576

merged 3 commits into from Jan 16, 2022

Conversation

stevenjoezhang
Copy link
Member

What does it do?

It's now very easy to check out a Pull Request with GitHub’s official command line tool: https://github.com/cli/cli

See also #3396

Screenshots

截屏2020-11-11 上午1 31 01

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Nov 10, 2020

Coverage Status

Coverage remained the same at 98.282% when pulling e40b096 on pr into eef2eac on master.

@SukkaW
Copy link
Member

SukkaW commented Dec 21, 2020

IMHO I might reject the PR.

  1. Not everyone uses GitHub CLI. I personally don't use GitHub CLI much.
  2. Even with GitHub CLI, npm i && npm test is still required.

ghost
ghost previously approved these changes Dec 22, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangtj
Copy link
Member

jiangtj commented Dec 22, 2020

If just run the test case, the Github Action is already executed. So I think this part is not necessary.

BTW, If you need to run PR in the project to see what happens, the command you might need to execute is yarn add <github-owner>/<package-name>#<ref>

I prefer to focus on the purpose of PR. Of course, I also saw how to contribute guidelines on the readme page of hexo. This is enough.

image

@SukkaW
Copy link
Member

SukkaW commented Dec 22, 2020

If just run the test case, the Github Action is already executed. So I think this part is not necessary.

Is It necessary to run a unit test even before creating a new PR.

I prefer to focus on the purpose of PR. Of course, I also saw how to contribute guidelines on the readme page of hexo. This is enough.

We might have to update the contributing guideline then.

@stevenjoezhang stevenjoezhang marked this pull request as draft August 17, 2021 12:56
@curbengh
Copy link
Contributor

I agree with this PR. Initially I thought npm i && npm test is redundant in a Node project, but I think it can be reminder especially to a PR creator, to run a test instead of solely relying on Action.

@stevenjoezhang stevenjoezhang marked this pull request as ready for review October 25, 2021 07:03
@github-actions github-actions bot added the stale label Dec 25, 2021
@SukkaW SukkaW merged commit 133679f into master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants