refactor(mail_to): use native URLSearchParams (#5002)

and the package "querystring" is deprecated.
hexojs · Jun 22, 2022 · 24db105 · 24db105
1 parent 8193550
commit 24db105
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/lib/plugins/helper/mail_to.js b/lib/plugins/helper/mail_to.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const { htmlTag } = require('hexo-util');
-const qs = require('querystring');
 const { default: moize } = require('moize');
 
 function mailToHelper(path, text, options = {}) {
@@ -28,7 +27,7 @@ function mailToHelper(path, text, options = {}) {
     }
   });
 
-  const querystring = qs.stringify(data);
+  const querystring = new URLSearchParams(data).toString();
   if (querystring) attrs.href += `?${querystring}`;
 
   return htmlTag('a', attrs, text);

diff --git a/test/scripts/helpers/mail_to.js b/test/scripts/helpers/mail_to.js
@@ -1,7 +1,5 @@
 'use strict';
 
-const qs = require('querystring');
-
 describe('mail_to', () => {
   const Hexo = require('../../../lib/hexo');
   const hexo = new Hexo(__dirname);
@@ -33,31 +31,31 @@ describe('mail_to', () => {
 
   it('cc (string)', () => {
     const data = {cc: 'abc@abc.com'};
-    const querystring = qs.stringify(data);
+    const querystring = new URLSearchParams(data).toString();
 
     mailto('abc@example.com', 'Email', {cc: 'abc@abc.com'})
       .should.eql('<a href="mailto:abc@example.com?' + querystring + '" title="Email">Email</a>');
   });
 
   it('cc (array)', () => {
     const data = {cc: 'abc@abc.com,bcd@bcd.com'};
-    const querystring = qs.stringify(data);
+    const querystring = new URLSearchParams(data).toString();
 
     mailto('abc@example.com', 'Email', {cc: ['abc@abc.com', 'bcd@bcd.com']})
       .should.eql('<a href="mailto:abc@example.com?' + querystring + '" title="Email">Email</a>');
   });
 
   it('bcc (string)', () => {
     const data = {bcc: 'abc@abc.com'};
-    const querystring = qs.stringify(data);
+    const querystring = new URLSearchParams(data).toString();
 
     mailto('abc@example.com', 'Email', {bcc: 'abc@abc.com'})
       .should.eql('<a href="mailto:abc@example.com?' + querystring + '" title="Email">Email</a>');
   });
 
   it('bcc (array)', () => {
     const data = {bcc: 'abc@abc.com,bcd@bcd.com'};
-    const querystring = qs.stringify(data);
+    const querystring = new URLSearchParams(data).toString();
 
     mailto('abc@example.com', 'Email', {bcc: ['abc@abc.com', 'bcd@bcd.com']})
       .should.eql('<a href="mailto:abc@example.com?' + querystring + '" title="Email">Email</a>');