fix(tocObj): return empty string

hexojs · Feb 23, 2020 · 6f796aa · 6f796aa
1 parent 6b18598
commit 6f796aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/lib/toc_obj.js b/lib/toc_obj.js
@@ -10,7 +10,7 @@ const parseHtml = html => {
 };
 
 const getId = ({ attribs, parent }) => {
-  return attribs.id || (!parent ? null : getId(parent));
+  return attribs.id || (!parent ? '' : getId(parent));
 };
 
 function tocObj(str, options = {}) {

diff --git a/test/toc_obj.spec.js b/test/toc_obj.spec.js
@@ -66,19 +66,15 @@ describe('tocObj', () => {
   it('no id attribute', () => {
     const noid = '<h1>Title 1</h1>';
     const result = tocObj(noid);
-    const checkNull = result[0].id === null;
 
-    result.length.should.eql(1);
-    checkNull.should.eql(true);
+    result[0].id.should.eql('');
   });
 
   it('empty value in id attribute', () => {
     const noid = '<h1 id="">Title 1</h1>';
     const result = tocObj(noid);
-    const checkNull = result[0].id === null;
 
-    result.length.should.eql(1);
-    checkNull.should.eql(true);
+    result[0].id.should.eql('');
   });
 
   it('invalid input', () => {