fix(is_external_link): handle invalid url

hexojs · Feb 16, 2020 · 12bdb3a · 12bdb3a
1 parent 7e084de
commit 12bdb3a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/is_external_link.js b/lib/is_external_link.js
@@ -16,8 +16,15 @@ function isExternalLink(input, sitehost, exclude) {
     sitehost = parse(sitehost).hostname || sitehost;
 
     if (!sitehost) return false;
-    // handle relative url
-    const data = new URL(input, `http://${sitehost}`);
+
+    // handle relative url and invalid url
+    let data;
+    try {
+      data = new URL(input, `http://${sitehost}`);
+    } catch (e) { }
+
+    // if input is invalid url, data should be undefined
+    if (typeof data !== 'object') return false;
 
     // handle mailto: javascript: vbscript: and so on
     if (data.origin === 'null') return false;

diff --git a/test/is_external_link.spec.js b/test/is_external_link.spec.js
@@ -9,6 +9,10 @@ describe('isExternalLink', () => {
 
   const isExternalLink = require('../lib/is_external_link');
 
+  it('invalid url', () => {
+    isExternalLink('https://localhost:4000你好', ctx.config.url).should.eql(false);
+  });
+
   it('external link', () => {
     isExternalLink('https://hexo.io/', ctx.config.url).should.eql(true);
   });