Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(#57): avoid creating instance each time when render each file #135

Merged
merged 2 commits into from Jan 2, 2022

Conversation

yoshinorin
Copy link
Member

Fix: #57

It is mentioned in #57 no need to create a new markdonw-it instance for each file.

@yoshinorin yoshinorin changed the title pref(#57): avoid creating instance each time when render each file perf(#57): avoid creating instance each time when render each file Oct 17, 2020
@SukkaW
Copy link
Member

SukkaW commented Jan 20, 2021

@J-Vin Thanks for your pinging this.

I will trigger a new CI test to see if the PR works as intended.

@tomap
Copy link
Contributor

tomap commented Jan 21, 2021

Why is this ci still travis and not github actions?

@yoshinorin yoshinorin merged commit ae545a8 into hexojs:master Jan 2, 2022
@yoshinorin yoshinorin deleted the fix/issue-57 branch January 2, 2022 13:45
ewfian added a commit to ewfian/hexo-renderer-markdown-it that referenced this pull request Feb 2, 2022
yoshinorin pushed a commit that referenced this pull request Feb 4, 2022
* fix(#135): filter was executed before it was loaded

* test: unit test enchancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why instantiate a new markdown renderer for each file processed?
3 participants