fix: issue #735 no required for arrays in swagger

hapi-swagger · Jun 11, 2022 · a3d27cb · a3d27cb
1 parent 22b74c2
commit a3d27cb
Show file tree

Hide file tree

Showing 4 changed files with 126 additions and 123 deletions.
diff --git a/lib/definitions.js b/lib/definitions.js
@@ -63,6 +63,11 @@ internals.append = function(definitionName, definition, currentCollection, force
 
   delete definition.optional;
 
+  // The "required" keyword is only applicable for objects not arrays
+  if (definition.required && definition.items !== undefined) {
+    delete definition.required
+  }
+
   // find definitionName by matching hash of object
   if (settings.reuseDefinitions) {
     foundDefinitionName = internals.hasDefinition(definition, currentCollection);

diff --git a/package.json b/package.json
@@ -53,7 +53,7 @@
     "handlebars": "^4.7.7",
     "http-status": "^1.5.2",
     "json-schema-ref-parser": "^6.1.0",
-    "swagger-parser": "4.0.2",
+    "swagger-parser": "^10.0.3",
     "swagger-ui-dist": "^4.11.1"
   },
   "devDependencies": {

diff --git a/test/Integration/responses-tests.js b/test/Integration/responses-tests.js
@@ -609,8 +609,7 @@ lab.experiment('responses', () => {
         type: 'array',
         items: {
           $ref: '#/definitions/datapoint'
-        },
-        required: ['datapoint']
+        }
       }
     });
     const isValid = await Validate.test(response.result);
@@ -663,8 +662,7 @@ lab.experiment('responses', () => {
         type: 'array',
         items: {
           $ref: '#/definitions/datapoint'
-        },
-        required: ['datapoint']
+        }
       }
     });
     const isValid = await Validate.test(response.result);