improve coverage for function 'toJoiObject'

hapi-swagger · Jun 9, 2022 · 2dde132 · 2dde132
1 parent 3106505
commit 2dde132
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/utilities.js b/lib/utilities.js
@@ -314,7 +314,7 @@ utilities.getJoiLabel = function(joiObj) {
  * @return {Object}
  */
 utilities.toJoiObject = function(obj) {
-  if (utilities.isJoi(obj) === false && utilities.isObject(obj)) {
+  if (!utilities.isJoi(obj) && utilities.isObject(obj)) {
     return Joi.object(obj);
   }
 

diff --git a/test/unit/utilities-test.js b/test/unit/utilities-test.js
@@ -176,8 +176,10 @@ lab.experiment('utilities', () => {
   });
 
   lab.test('toJoiObject', () => {
-    expect(Joi.isSchema(Utilities.toJoiObject({}))).to.equal(true)
-    expect(Joi.isSchema(Utilities.toJoiObject(Joi.object()))).to.equal(true)
+    expect(Joi.isSchema(Utilities.toJoiObject([]))).to.equal(false);
+    expect(Joi.isSchema(Utilities.toJoiObject(Object.create(null)))).to.equal(true);
+    expect(Joi.isSchema(Utilities.toJoiObject({}))).to.equal(true);
+    expect(Joi.isSchema(Utilities.toJoiObject(Joi.object()))).to.equal(true);
   });
 
   lab.test('hasJoiMeta', () => {