Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file.clone() break symlink #143

Closed
GongT opened this issue Jan 4, 2019 · 0 comments · Fixed by #146
Closed

file.clone() break symlink #143

GongT opened this issue Jan 4, 2019 · 0 comments · Fixed by #146
Projects
v5

Comments

@GongT
Copy link

GongT commented Jan 4, 2019 •
edited 

const VinylFile = require('vinyl')
const a = new VinylFile({stat: Object.assign(new fs.Stats, {mode: 41453}) , symlink: 'xxxx' })
console.log(a.symlink , a.isSymbolic())  // xxxx true
const b = a.clone()
console.log(b.symlink , b.isSymbolic())  // null true
@phated phated added this to TODO in v4 Apr 6, 2019
Blaimi added a commit to krumedia/vinyl that referenced this issue Nov 20, 2019
@Blaimi
fix file.clone() if file is a symbolic link
6ff569a 
Closes: gulpjs#143
@Blaimi Blaimi mentioned this issue Nov 20, 2019
Merged
@phated phated removed this from TODO in v4 Apr 28, 2020
@phated phated added this to To do in v5 Apr 28, 2020
phated pushed a commit that referenced this issue Sep 22, 2020
@Blaimi
Fix: Ensure symbolic link files are cloned properly (closes #143) (#146)
df22ac0
phated pushed a commit that referenced this issue Sep 22, 2020
@Blaimi @phated
Fix: Ensure symbolic link files are cloned properly (closes #143) (#146)
b5e1570
@phated phated moved this from To do to Done in v5 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix file.clone() if file is a symbolic link krumedia/vinyl
1 participant
@GongT