Skip to content

Commit

Permalink
Build: Avoid referencing deprecated Buffer() & update tests to use sa…
Browse files Browse the repository at this point in the history
…fer-buffer (#142)
  • Loading branch information
lpinca authored and phated committed Sep 22, 2020
1 parent 02c8923 commit ec0ca87
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 17 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -27,7 +27,7 @@ var jsFile = new Vinyl({
cwd: '/',
base: '/test/',
path: '/test/file.js',
contents: new Buffer('var x = 123')
contents: Buffer.from('var x = 123')
});
```

Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -42,7 +42,8 @@
"jscs": "^2.3.5",
"jscs-preset-gulp": "^1.0.0",
"mississippi": "^1.2.0",
"mocha": "^2.4.5"
"mocha": "^2.4.5",
"safer-buffer": "^2.1.2"
},
"keywords": [
"virtual",
Expand Down
32 changes: 17 additions & 15 deletions test/file.js
Expand Up @@ -6,13 +6,15 @@ var util = require('util');
var expect = require('expect');
var miss = require('mississippi');
var cloneable = require('cloneable-readable');
var saferBuffer = require('safer-buffer');

var File = require('../');

var pipe = miss.pipe;
var from = miss.from;
var concat = miss.concat;
var isCloneable = cloneable.isCloneable;
var Buffer = saferBuffer.Buffer;

var isWin = (process.platform === 'win32');

Expand Down Expand Up @@ -162,7 +164,7 @@ describe('File', function() {
});

it('sets contents', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val });
expect(file.contents).toEqual(val);
done();
Expand Down Expand Up @@ -269,7 +271,7 @@ describe('File', function() {
describe('isBuffer()', function() {

it('returns true when the contents are a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val });
expect(file.isBuffer()).toEqual(true);
done();
Expand All @@ -292,7 +294,7 @@ describe('File', function() {
describe('isStream()', function() {

it('returns false when the contents are a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val });
expect(file.isStream()).toEqual(false);
done();
Expand All @@ -315,7 +317,7 @@ describe('File', function() {
describe('isNull()', function() {

it('returns false when the contents are a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val });
expect(file.isNull()).toEqual(false);
done();
Expand Down Expand Up @@ -343,7 +345,7 @@ describe('File', function() {
};

it('returns false when the contents are a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val, stat: fakeStat });
expect(file.isDirectory()).toEqual(false);
done();
Expand Down Expand Up @@ -383,7 +385,7 @@ describe('File', function() {
};

it('returns false when the contents are a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val, stat: fakeStat });
expect(file.isSymbolic()).toEqual(false);
done();
Expand Down Expand Up @@ -422,7 +424,7 @@ describe('File', function() {
cwd: '/',
base: '/test/',
path: '/test/test.coffee',
contents: new Buffer('test'),
contents: Buffer.from('test'),
};
var file = new File(options);
var file2 = file.clone();
Expand All @@ -441,7 +443,7 @@ describe('File', function() {
cwd: '/',
base: '/test/',
path: '/test/test.js',
contents: new Buffer('test'),
contents: Buffer.from('test'),
};
var file = new File(options);

Expand Down Expand Up @@ -598,7 +600,7 @@ describe('File', function() {
cwd: '/',
base: '/test/',
path: '/test/test.js',
contents: new Buffer('test'),
contents: Buffer.from('test'),
stat: fs.statSync(__filename),
};

Expand All @@ -617,7 +619,7 @@ describe('File', function() {
cwd: path.normalize('/'),
base: path.normalize('/test/'),
path: path.normalize('/test/test.js'),
contents: new Buffer('test'),
contents: Buffer.from('test'),
};

var file = new File(options);
Expand Down Expand Up @@ -757,14 +759,14 @@ describe('File', function() {
});

it('returns correct format when Buffer contents and no path', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({ contents: val });
expect(file.inspect()).toEqual('<File <Buffer 74 65 73 74>>');
done();
});

it('returns correct format when Buffer contents and relative path', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File({
cwd: '/',
base: '/test/',
Expand Down Expand Up @@ -801,23 +803,23 @@ describe('File', function() {
describe('contents get/set', function() {

it('returns _contents', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File();
file._contents = val;
expect(file.contents).toEqual(val);
done();
});

it('sets _contents', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File();
file.contents = val;
expect(file._contents).toEqual(val);
done();
});

it('sets a Buffer', function(done) {
var val = new Buffer('test');
var val = Buffer.from('test');
var file = new File();
file.contents = val;
expect(file.contents).toEqual(val);
Expand Down

0 comments on commit ec0ca87

Please sign in to comment.