Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load ts config file synchronously #344

Merged
merged 1 commit into from Nov 24, 2021

Conversation

alvis
Copy link
Contributor

@alvis alvis commented Nov 20, 2021

This PR makes config loading from a TS file synchronous.

Fix #290

@patricklafrance patricklafrance merged commit ed076ff into dilanx:master Nov 24, 2021
@patricklafrance
Copy link
Contributor

LGTM, thanks @alvis :)

@patricklafrance
Copy link
Contributor

Released in https://www.npmjs.com/package/@craco/craco/v/6.4.2

@Sneaken
Copy link

Sneaken commented Nov 26, 2021

It doesn’t work. I don’t know if it’s the version of ts-node. The version of ts-node is not indicated here.

Below is my error:

export default {
^^^^^^

SyntaxError: Unexpected token 'export'

@alvis
Copy link
Contributor Author

alvis commented Nov 27, 2021

@Sneaken could you share your tsconfig.json?
seems like you have set module other than 'commonjs', which is required by ts-node to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow craco config to be written in Typescript
3 participants