Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config 'craco.config.cjs' to support for ES6 module #343

Merged
merged 1 commit into from Nov 19, 2021

Conversation

shibin2021
Copy link
Contributor

@shibin2021 shibin2021 commented Nov 19, 2021

When the react project is using ES6 module(using type="module" in package.json), we need to craco to support config file craco.config.cjs.

@patricklafrance patricklafrance merged commit cdd02fc into dilanx:master Nov 19, 2021
@patricklafrance
Copy link
Contributor

Merged, thanks for the PR @shibin2021 :)

@patricklafrance
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants