Commit
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ node_js: | |
| - "4" | ||
| - "6" | ||
| - "8" | ||
| - "10" | ||
|
|
||
| matrix: | ||
| fast_finish: true | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -446,7 +446,6 @@ module.exports = function(grunt) { | |
| grunt.loadNpmTasks('grunt-contrib-jshint'); | ||
| grunt.loadNpmTasks('grunt-contrib-clean'); | ||
| grunt.loadNpmTasks('grunt-contrib-nodeunit'); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
alexlamsl
Author
Contributor
|
||
|
|
||
| // Whenever the "test" task is run, first clean the "tmp" dir, then run this | ||
| // plugin's task(s), then test the result. | ||
|
|
||
13 comments
on commit f6f834b
There was a problem hiding this comment.
@alexlamsl: unless you enable 2FA for npm auth/push, you can't publish.
There was a problem hiding this comment.
@XhmikosR I don't intend to do the actual publishing, since I have only put in the code changes required to upgrade to uglify-js@3.4.x without any test failures.
Feel free to pick up from here.
There was a problem hiding this comment.
Well, you should be able to publish. Just enable 2FA.
Note that unless you CC me, I don't watch any repos due to the number of notifications.
There was a problem hiding this comment.
I shall include /cc in the PR description next time.
There was a problem hiding this comment.
@alexlamsl: so, will you enable 2FA on npm? That way we could go back to the review and publish procedure.
There was a problem hiding this comment.
@XhmikosR sorry I was out the whole day so I couldn't do anything besides simply replying to your earlier messages.
I had a look at the blog post you sent me earlier, but I couldn't make out the heads and tails of this beta feature - any more concrete step-by-step pointers? In particular I don't seem to find any mention on which side channel(s) npm would deliver that extra authentication code.
There was a problem hiding this comment.
@alexlamsl for your npm account see https://docs.npmjs.com/getting-started/using-two-factor-authentication. You can do it via the web interface, nothing too weird :P
For your repos, go to https://www.npmjs.com/package/<REPLACE_ME)/access and Enable the option to Require Two Factor Authentication to publish or modify settings
There was a problem hiding this comment.
@XhmikosR thanks for the helpful pointers - I've definitely missed the first part (I don't frequent npmjs.com much, let alone logging in onto it...)
Got myself a QR code and trying to make sense out of otpauth:// as I don't have anything on my phone that would work with it.
There was a problem hiding this comment.
Right got it - this is certainly not straight forward for someone who doesn't have Google attached to his daily life.
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's get back to the business of updating documentation. I have added to CHANGELOG but npm test certainly doesn't update README.md - and running grunt gives:
Warning: Task "build-contrib" not found. Use --force to continue.
Aborted due to warnings.
There was a problem hiding this comment.
Ah, never mind - I've figured that part out.
There was a problem hiding this comment.
Would be nice if you made PRs so that one can review before making such changes.