Allow newlines in Resource Paths (#114)

googleapis · Jan 24, 2018 · 19c3a15 · 19c3a15
1 parent 5be8477
commit 19c3a15
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/path.js b/src/path.js
@@ -27,7 +27,9 @@ const validate = require('./validate')();
  *
  * @type {RegExp}
  */
-const RESOURCE_PATH_RE = /^projects\/([^/]*)\/databases\/([^/]*)(?:\/documents\/)?(.*)$/;
+const RESOURCE_PATH_RE =
+  // Note: [\s\S] matches all characters including newlines.
+  /^projects\/([^/]*)\/databases\/([^/]*)(?:\/documents\/)?([\s\S]*)$/;
 
 /*!
  * A regular expression to verify whether a field name can be passed to the
@@ -295,6 +297,7 @@ class ResourcePath extends Path {
   get databaseId() {
     return this._databaseId;
   }
+
   /**
    * Returns true if the given string can be used as a relative or absolute
    * resource path.

diff --git a/test/path.js b/test/path.js
@@ -61,6 +61,13 @@ describe('ResourcePath', function() {
       );
     }, /Resource name 'projects\/project\/databases' is not valid\./);
   });
+
+  it('accepts newlines', function() {
+    const path = ResourcePath.fromSlashSeparatedString(
+      `${DATABASE_ROOT}/documents/foo\nbar`
+    );
+    assert.equal(path.formattedName, `${DATABASE_ROOT}/documents/foo\nbar`);
+  });
 });
 
 describe('FieldPath', function() {