Skip to content

Commit

Permalink
refactor(types): enable noImplicitAny for transaction.ts & request.ts (
Browse files Browse the repository at this point in the history
  • Loading branch information
Joe Cervino authored and JustinBeckwith committed Feb 8, 2019
1 parent dc66029 commit a2acca3
Show file tree
Hide file tree
Showing 9 changed files with 13,818 additions and 179 deletions.
7 changes: 5 additions & 2 deletions package.json
Expand Up @@ -37,10 +37,12 @@
"clean": "gts clean",
"compile": "tsc -p . && cp -r src/v1 build/src && cp -r protos build && cp test/*.js build/test",
"prepare": "npm run compile",
"pretest": "npm run compile"
"pretest": "npm run compile",
"proto": "npm run proto:datastore",
"proto:datastore": "mkdir -p proto && pbjs -t static-module -w commonjs -p node_modules/google-proto-files google/datastore/v1/datastore.proto | pbts -o proto/datastore.d.ts -"
},
"dependencies": {
"@google-cloud/projectify": "^0.3.0",
"@google-cloud/projectify": "^0.3.2",
"@google-cloud/promisify": "^0.3.0",
"arrify": "^1.0.1",
"concat-stream": "^2.0.0",
Expand Down Expand Up @@ -68,6 +70,7 @@
"eslint-config-prettier": "^4.0.0",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-prettier": "^3.0.0",
"google-proto-files": "^0.18.0",
"gts": "^0.9.0",
"jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
"intelli-espower-loader": "^1.0.1",
Expand Down
8,865 changes: 8,865 additions & 0 deletions proto/datastore.d.ts

Large diffs are not rendered by default.

4,613 changes: 4,613 additions & 0 deletions proto/entity.d.ts

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/entity.ts
Expand Up @@ -42,7 +42,7 @@ export namespace entity {
* @type {symbol}
* @private
*/
export const KEY_SYMBOL = Symbol('KEY');
export const KEY_SYMBOL: unique symbol = Symbol('KEY');

/**
* Build a Datastore Double object. For long doubles, a string can be
Expand Down Expand Up @@ -530,7 +530,7 @@ export namespace entity {
};

if (excludeFromIndexes && excludeFromIndexes.length > 0) {
excludeFromIndexes.forEach(excludePath => {
excludeFromIndexes.forEach((excludePath: string) => {
excludePathFromEntity(entityProto, excludePath);
});
}
Expand Down
1 change: 0 additions & 1 deletion src/index.ts
Expand Up @@ -579,7 +579,6 @@ class Datastore extends DatastoreRequest {
static KEY = entity.KEY_SYMBOL;
KEY = Datastore.KEY;


/**
* This is one of three values which may be returned from
* {@link Datastore#runQuery}, {@link Transaction#runQuery}, and
Expand Down

0 comments on commit a2acca3

Please sign in to comment.