fix: use req.ip in express and koa plugin (#944)

googleapis · Dec 17, 2018 · 126bc75 · 126bc75
1 parent 0b404a1
commit 126bc75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/plugins/plugin-express.ts b/src/plugins/plugin-express.ts
@@ -61,7 +61,7 @@ function patchModuleRoot(express: Express4Module, api: PluginTypes.Tracer) {
       const url = `${req.protocol}://${req.headers.host}${req.originalUrl}`;
       rootSpan.addLabel(labels.HTTP_METHOD_LABEL_KEY, req.method);
       rootSpan.addLabel(labels.HTTP_URL_LABEL_KEY, url);
-      rootSpan.addLabel(labels.HTTP_SOURCE_IP, req.connection.remoteAddress);
+      rootSpan.addLabel(labels.HTTP_SOURCE_IP, req.ip);
 
       // wrap end
       const originalEnd = res.end;

diff --git a/src/plugins/plugin-koa.ts b/src/plugins/plugin-koa.ts
@@ -86,7 +86,7 @@ function startSpanForRequest<T>(
     // middlewear runs.
     root.addLabel(api.labels.HTTP_METHOD_LABEL_KEY, req.method);
     root.addLabel(api.labels.HTTP_URL_LABEL_KEY, url);
-    root.addLabel(api.labels.HTTP_SOURCE_IP, req.connection.remoteAddress);
+    root.addLabel(api.labels.HTTP_SOURCE_IP, ctx.request.ip);
 
     // wrap end
     res.end = function(this: ServerResponse) {