fix(deps): update @google-cloud/common to ^0.23.0 (#506)

package.json

@@ -56,15 +56,14 @@
     "once": "^1.4.0",
     "post-install-check": "0.0.1",
     "proxyquire": "^2.0.0",
-    "request": "^2.81.0",
     "rimraf": "^2.6.2",
     "source-map-support": "^0.5.6",
     "tmp": "0.0.33",
     "tslint": "^5.4.3",
     "typescript": "~2.9.1"
   },
   "dependencies": {
-    "@google-cloud/common": "^0.20.3",
+    "@google-cloud/common": "^0.23.0",
     "acorn": "^5.0.3",
     "coffeescript": "^2.0.0",
     "console-log-level": "^1.4.0",
@@ -73,6 +72,7 @@
     "gcp-metadata": "^0.7.0",
     "lodash": "^4.12.0",
     "p-limit": "^2.0.0",
+    "request": "^2.81.0",
     "semver": "^5.5.0",
     "source-map": "^0.6.1",
     "split": "^1.0.0",

src/agent/controller.ts

@@ -20,9 +20,8 @@
 
 import {ServiceObject} from '@google-cloud/common';
 import * as assert from 'assert';
-import * as http from 'http';
 import * as qs from 'querystring';
-import {Response} from 'request';
+import * as request from 'request';
 
 import {Debug} from '../client/stackdriver/debug';
 import {Debuggee} from '../debuggee';
@@ -38,7 +37,11 @@ export class Controller extends ServiceObject {
    * @constructor
    */
   constructor(debug: Debug) {
-    super({parent: debug, baseUrl: '/controller'});
+    super({
+      requestModule: request,
+      parent: debug,
+      baseUrl: '/controller'
+    });
 
     /** @private {string} */
     this.nextWaitToken = null;
@@ -83,7 +86,7 @@ export class Controller extends ServiceObject {
   listBreakpoints(
       debuggee: Debuggee,
       callback:
-          (err: Error|null, response?: Response,
+          (err: Error|null, response?: request.Response,
            body?: stackdriver.ListBreakpointsResponse) => void): void {
     const that = this;
     assert(debuggee.id, 'should have a registered debuggee');

src/client/stackdriver/debug.ts

@@ -15,6 +15,7 @@
  */
 
 import {GoogleAuthOptions, Service} from '@google-cloud/common';
+import * as request from 'request';
 
 export interface PackageInfo {
   name: string;
@@ -56,6 +57,7 @@ export class Debug extends Service {
     }
 
     const config = {
+      requestModule: request,
       projectIdRequired: false,
       baseUrl: 'https://clouddebugger.googleapis.com/v2',
       scopes: ['https://www.googleapis.com/auth/cloud_debugger'],

test/debugger.ts

@@ -22,6 +22,7 @@ import {ServiceObject} from '@google-cloud/common';
 import {Debug} from '../src/client/stackdriver/debug';
 import {Debuggee} from '../src/debuggee';
 import * as stackdriver from '../src/types/stackdriver';
+import * as request from 'request';
 
 // TODO: Verify these types are correct.
 const qs: {
@@ -43,7 +44,11 @@ export class Debugger extends ServiceObject {
    * @constructor
    */
   constructor(debug: Debug) {
-    super({parent: debug, baseUrl: '/debugger'});
+    super({
+      requestModule: request,
+      parent: debug,
+      baseUrl: '/debugger'
+    });
 
     /** @private {string} */
     this.nextWaitToken = null;