chore(gatsby): drop eslint-plugin-graphql (#36364)

gatsbyjs · Aug 19, 2022 · b361081 · b361081
1 parent 2e67161
commit b361081
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 396 deletions.
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -72,7 +72,6 @@
     "eslint": "^7.32.0",
     "eslint-config-react-app": "^6.0.0",
     "eslint-plugin-flowtype": "^5.10.0",
-    "eslint-plugin-graphql": "^4.0.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsx-a11y": "^6.5.1",
     "eslint-plugin-react": "^7.30.1",

diff --git a/packages/gatsby/src/utils/eslint-config.ts b/packages/gatsby/src/utils/eslint-config.ts
@@ -1,4 +1,3 @@
-import { printSchema, GraphQLSchema } from "graphql"
 import { ESLint } from "eslint"
 import path from "path"
 
@@ -37,7 +36,6 @@ export const eslintRequiredConfig: ESLint.Options = {
 }
 
 export const eslintConfig = (
-  schema: GraphQLSchema,
   usingAutomaticJsxRuntime: boolean
 ): ESLint.Options => {
   return {
@@ -69,7 +67,7 @@ export const eslintConfig = (
         },
         requireConfigFile: false,
       },
-      plugins: [`graphql`],
+      plugins: [],
       rules: {
         // New versions of react use a special jsx runtime that remove the requirement
         // for having react in scope for jsx. Once the jsx runtime is backported to all
@@ -79,14 +77,6 @@ export const eslintConfig = (
         "react/jsx-uses-react": usingAutomaticJsxRuntime ? `off` : `error`,
         "react/react-in-jsx-scope": usingAutomaticJsxRuntime ? `off` : `error`,
         "import/no-webpack-loader-syntax": [0],
-        "graphql/template-strings": [
-          `error`,
-          {
-            env: `relay`,
-            schemaString: printSchema(schema, { commentDescriptions: true }),
-            tagName: `graphql`,
-          },
-        ],
         "react/jsx-pascal-case": [
           `warn`,
           {

diff --git a/packages/gatsby/src/utils/gatsby-webpack-eslint-graphql-schema-reload-plugin.ts b/packages/gatsby/src/utils/gatsby-webpack-eslint-graphql-schema-reload-plugin.ts
diff --git a/packages/gatsby/src/utils/webpack-utils.ts b/packages/gatsby/src/utils/webpack-utils.ts
@@ -13,7 +13,6 @@ import { getBrowsersList } from "./browserslist"
 import ESLintPlugin from "eslint-webpack-plugin"
 import { cpuCoreCount } from "gatsby-core-utils"
 import { GatsbyWebpackStatsExtractor } from "./gatsby-webpack-stats-extractor"
-import { GatsbyWebpackEslintGraphqlSchemaReload } from "./gatsby-webpack-eslint-graphql-schema-reload-plugin"
 import {
   GatsbyWebpackVirtualModules,
   VIRTUAL_MODULES_BASE_PATH,
@@ -38,7 +37,7 @@ type ContextualRuleFactory<T = Record<string, unknown>> = RuleFactory<T> & {
   external?: RuleFactory<T>
 }
 
-type PluginFactory = (...args: any) => WebpackPluginInstance
+type PluginFactory = (...args: any) => WebpackPluginInstance | null
 
 type BuiltinPlugins = typeof builtinPlugins
 
@@ -785,22 +784,21 @@ export const createWebpackUtils = (
   plugins.extractStats = (): GatsbyWebpackStatsExtractor =>
     new GatsbyWebpackStatsExtractor()
 
-  plugins.eslintGraphqlSchemaReload =
-    (): GatsbyWebpackEslintGraphqlSchemaReload =>
-      new GatsbyWebpackEslintGraphqlSchemaReload()
+  // TODO: remove this in v5
+  plugins.eslintGraphqlSchemaReload = (): null => null
 
   plugins.virtualModules = (): GatsbyWebpackVirtualModules =>
     new GatsbyWebpackVirtualModules()
 
-  plugins.eslint = (schema: GraphQLSchema): WebpackPluginInstance => {
+  plugins.eslint = (): WebpackPluginInstance => {
     const options = {
       extensions: [`js`, `jsx`],
       exclude: [
         `/node_modules/`,
         `/bower_components/`,
         VIRTUAL_MODULES_BASE_PATH,
       ],
-      ...eslintConfig(schema, config.jsxRuntime === `automatic`),
+      ...eslintConfig(config.jsxRuntime === `automatic`),
     }
     // @ts-ignore
     return new ESLintPlugin(options)

diff --git a/packages/gatsby/src/utils/webpack.config.js b/packages/gatsby/src/utils/webpack.config.js
@@ -249,7 +249,6 @@ module.exports = async (
             new ForceCssHMRForEdgeCases(),
             plugins.hotModuleReplacement(),
             plugins.noEmitOnErrors(),
-            plugins.eslintGraphqlSchemaReload(),
             new StaticQueryMapper(store),
           ])
           .filter(Boolean)
@@ -266,12 +265,10 @@ module.exports = async (
         }
 
         const isCustomEslint = hasLocalEslint(program.directory)
-        // get schema to pass to eslint config and program for directory
-        const { schema } = store.getState()
 
         // if no local eslint config, then add gatsby config
         if (!isCustomEslint) {
-          configPlugins.push(plugins.eslint(schema))
+          configPlugins.push(plugins.eslint())
         }
 
         // Enforce fast-refresh rules even with local eslint config