fix(gatsby): Handle renderToPipeableStream errors (#36555)

gatsbyjs · Sep 7, 2022 · 9c5eacf · 9c5eacf
1 parent 42e241c
commit 9c5eacf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/gatsby/cache-dir/server-utils/writable-as-promise.js b/packages/gatsby/cache-dir/server-utils/writable-as-promise.js
@@ -16,15 +16,21 @@ export class WritableAsPromise extends Writable {
     })
   }
 
-  _write(chunk, enc, cb) {
+  _write(chunk, _, next) {
     this._output += chunk.toString()
+    next()
+  }
 
-    cb()
+  _destroy(error, next) {
+    if (error instanceof Error) {
+      this._deferred.reject(error)
+    } else {
+      next()
+    }
   }
 
   end() {
     this._deferred.resolve(this._output)
-
     this.destroy()
   }
 

diff --git a/packages/gatsby/cache-dir/static-entry.js b/packages/gatsby/cache-dir/static-entry.js
@@ -294,7 +294,7 @@ export default async function staticPage({
               pipe(writableStream)
             },
             onError(error) {
-              throw error
+              writableStream.destroy(error)
             },
           })