Revert "fix(wordpress): ensure all file links are rewritten" (#32398) (…

…#32422)

This reverts commit f970600.

(cherry picked from commit 9e96088)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>

packages/gatsby-source-wordpress/src/steps/source-nodes/fetch-nodes/fetch-referenced-media-items.js

@@ -271,7 +271,7 @@ const processAndDedupeImageUrls = urls =>
     }, urls)
   )
 
-export const fetchMediaItemsBySourceUrl = async ({
+const fetchMediaItemsBySourceUrl = async ({
   mediaItemUrls,
   selectionSet,
   builtFragments,
@@ -319,16 +319,10 @@ export const fetchMediaItemsBySourceUrl = async ({
   // we pass this resolve function into the queue function so it can let us
   // know when it's finished
   let resolveFutureNodes
-  const allResolvedNodes = [...previouslyCachedMediaItemNodes]
-  let resolveCountTogo = mediaItemUrlsPages.length
   const futureNodes = new Promise(resolve => {
-    // combine our resolved nodes we fetched with our cached nodes
-    resolveFutureNodes = (nodes = []) => {
-      allResolvedNodes.push(...nodes)
-      if (--resolveCountTogo === 0) {
-        resolve(allResolvedNodes)
-      }
-    }
+    resolveFutureNodes = (nodes = []) =>
+      // combine our resolved nodes we fetched with our cached nodes
+      resolve([...nodes, ...previouslyCachedMediaItemNodes])
   })
 
   // we have no media items to fetch,