fix(gatsby): handle cyclic chunkgroup children (#38052)

gatsbyjs · May 3, 2023 · 272dacd · 272dacd
1 parent a83ed19
commit 272dacd
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/gatsby/src/utils/webpack/get-ssr-chunk-hashes.ts b/packages/gatsby/src/utils/webpack/get-ssr-chunk-hashes.ts
@@ -6,8 +6,14 @@ type ChunkGroup = webpack.Compilation["chunkGroups"][0]
 function getHashes(
   chunkGroup: ChunkGroup,
   compilation: webpack.Compilation,
-  hashes: Array<string> = []
+  hashes: Array<string> = [],
+  visitedChunkGroups: Set<ChunkGroup> = new Set()
 ): Array<string> {
+  if (visitedChunkGroups.has(chunkGroup)) {
+    return hashes
+  }
+  visitedChunkGroups.add(chunkGroup)
+
   for (const chunk of chunkGroup.chunks) {
     if (!chunk.hash) {
       throw new Error(
@@ -23,7 +29,7 @@ function getHashes(
     )
 
     if (isNotImportedByAsyncRequires) {
-      getHashes(childChunkGroup, compilation, hashes)
+      getHashes(childChunkGroup, compilation, hashes, visitedChunkGroups)
     }
   }