This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Read client secret from env var first since the location has a default #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Aug 9, 2022
hamersaw
approved these changes
Aug 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 74.70% 74.70%
=======================================
Files 15 15
Lines 1000 1000
=======================================
Hits 747 747
Misses 222 222
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
#312) Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Missed in #311
The client secret location has a default value so it's always non-empty and read before attempting to fetch the secret value.
Type
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#2744
Follow-up issue
NA