This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Allow passing in authentication client secret as an environment variable #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 75.05% 74.70% -0.36%
==========================================
Files 15 15
Lines 994 1000 +6
==========================================
+ Hits 746 747 +1
- Misses 217 222 +5
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pmahindrakar-oss
previously approved these changes
Aug 9, 2022
| logger.Errorf(ctx, "Error reading secret from location %s", cfg.ClientSecretLocation) | ||
| return nil, err | ||
| } | ||
| secret = strings.TrimSpace(string(secretBytes)) |
There was a problem hiding this comment.
Can we have this done in both the conditions
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pmahindrakar-oss
approved these changes
Aug 9, 2022
EngHabu
approved these changes
Aug 9, 2022
wild-endeavor
approved these changes
Aug 9, 2022
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Allow passing in authentication client secret as an environment variable in addition to file path location
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2744
Follow-up issue
NA