Skip to content

Commit

Permalink
1.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
caub committed Aug 24, 2021
1 parent fef3933 commit fbf6dac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lib/prompt.js
Expand Up @@ -396,14 +396,14 @@ prompt.confirm = function (/* msg, options, callback */) {
function confirm(target, next) {
var yes = target.yes || RX_Y,
options = {
description: typeof target === 'string' ? target : target.description||'yes/no',
description: typeof target === 'string' ? target : target.description || 'yes/no',
pattern: target.pattern || RX_YN,
name: 'confirm',
message: target.message || 'yes/no'
};

for(var k in (opts || {})) {
if(opts.hasOwnProperty(k)) {
for (var k in (opts || {})) {
if (opts.hasOwnProperty(k)) {
options[k] = opts[k];
}
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "prompt",
"version": "1.1.0",
"version": "1.2.0",
"description": "A beautiful command-line prompt for node.js",
"author": "Nodejitsu Inc. <info@nodejitsu.com>",
"maintainers": [
Expand Down

4 comments on commit fbf6dac

@mizevkon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caub could you please share if there are plans for releasing 1.2.0 to npm in the nearest future? Thanks

@caub
Copy link
Contributor Author

@caub caub commented on fbf6dac Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mizevkon I was going to do it, but I wanted first to know how you chose the async ~0.9.x version here https://github.com/flatiron/prompt/pull/216/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21? based on what please? do versions above don't pass the tests or don't support all node versions?

Thanks again for your work

@mizevkon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caub it is original version from utile - I decided to be on safe side and do not bump it.
Plus, I have tried async@latest and it did not pass the tests, rejectSeries part was the problem: ✗ Errored » callback not fired in .confirm() tests

@caub
Copy link
Contributor Author

@caub caub commented on fbf6dac Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, v1.2.0 published now

Please sign in to comment.