Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbf6dac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caub could you please share if there are plans for releasing 1.2.0 to npm in the nearest future? Thanks
fbf6dac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mizevkon I was going to do it, but I wanted first to know how you chose the async ~0.9.x version here https://github.com/flatiron/prompt/pull/216/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21? based on what please? do versions above don't pass the tests or don't support all node versions?
Thanks again for your work
fbf6dac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caub it is original version from utile - I decided to be on safe side and do not bump it.
Plus, I have tried
async@latest
and it did not pass the tests,rejectSeries
part was the problem:✗ Errored » callback not fired
in .confirm() testsfbf6dac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks, v1.2.0 published now