Merge pull request #163 from Eagerod/fixer/add-properties

Fixed a callback issue in addProperties
flatiron · Oct 27, 2016 · d550674 · d550674
2 parents e7b5449 + 9b5f65b
commit d550674
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/prompt.js b/lib/prompt.js
@@ -689,7 +689,7 @@ prompt.addProperties = function (obj, properties, callback) {
   });
 
   if (properties.length === 0) {
-    return callback(obj);
+    return callback(null, obj);
   }
 
   prompt.get(properties, function (err, results) {

diff --git a/test/prompt-test.js b/test/prompt-test.js
@@ -647,6 +647,20 @@ vows.describe('prompt').addBatch({
       }
     }
   }
+}).addBatch({
+  "When using prompt": {
+    "the addProperties() method": {
+      topic: function () {
+        prompt.addProperties({'foo': 'foo', 'bar': 'bar'}, [], this.callback);
+      },
+      "should return the object as-is when no properties provided": function (err, obj) {
+        assert.isNull(err);
+        assert.isObject(obj);
+        assert.equal(obj.foo, 'foo');
+        assert.equal(obj.bar, 'bar');
+      }
+    }
+  }
 }).addBatch({
   "When using prompt": {
     "the get() method": {