Skip to content

Commit

Permalink
shrinkwrap CLI dependencies (#4004)
Browse files Browse the repository at this point in the history
* create shrinkwrap file

* update tests to check for shrinkwrap

* add changelog
  • Loading branch information
bkendall committed Jan 11, 2022
1 parent dfaa859 commit 9ae4fef
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/node-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/npm-shrinkwrap.json') }}

- run: npm i -g npm@8
- run: npm ci
Expand All @@ -51,7 +51,7 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/npm-shrinkwrap.json') }}

- run: npm i -g npm@8
- run: npm ci
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/npm-shrinkwrap.json') }}

- name: Cache firebase emulators
uses: actions/cache@v2
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
- run: npm i -g npm@8
# --ignore-scripts prevents the `prepare` script from being run.
- run: npm install --package-lock-only --ignore-scripts
- run: "git diff --exit-code -- package-lock.json || (echo 'Error: package-lock.json is changed during npm install! Please make sure to use npm >= 8 and commit package-lock.json.' && false)"
- run: "git diff --exit-code -- npm-shrinkwrap.json || (echo 'Error: npm-shrinkwrap.json is changed during npm install! Please make sure to use npm >= 8 and commit npm-shrinkwrap.json.' && false)"

check-json-schema:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Now publishes npm-shrinkwrap.json which pins dependencies for the CLI.
- Preserve empty vpc connector setting on function deploy. (#3973)
- Upgrades google-auth-library to 7.x.x, enabling support for workload identity federation
File renamed without changes.

0 comments on commit 9ae4fef

Please sign in to comment.