fix: HEAD route reseting #5090

ivan-tymoshenko · 2023-10-11T22:31:42Z

climba03003 · 2023-10-12T03:38:14Z

lib/route.js

@@ -327,7 +327,7 @@ function buildRouting (options) {

      // remove the head route created by fastify
      if (hasHEADHandler && !context[kRouteByFastify] && headHandler.store[kRouteByFastify]) {
-        router.off('HEAD', opts.url, { constraints })
+        router.off('HEAD', opts.url, constraints)


~~Why .on and .off is not using the same syntax?~~
Double checked on find-my-way, it is actually not the same.

climba03003 · 2023-10-12T03:40:04Z

Some test need to be adjusted.

ivan-tymoshenko · 2023-10-12T08:24:26Z

Some test need to be adjusted.

What tests?

ivan-tymoshenko · 2023-10-12T08:57:16Z

Can't tell now, but having that this tests shouldn't fail, it looks like another bug in fastify.

ivan-tymoshenko · 2023-10-12T10:25:32Z

I didn't expect it to be broken on so many levels.

mcollina

lgtm

climba03003

The logic looks fine.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.24.0` -> `4.24.1`](https://renovatebot.com/diffs/npm/fastify/4.24.0/4.24.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) #### What's Changed - fix: citgm by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [fastify/fastify#5075 - fix: HEAD route reseting by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [fastify/fastify#5090 **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.23.2` -> `4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3) #### What's Changed - fix: timeout on citgm tests by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [fastify/fastify#5101 - chore: add missing `use strict` directives by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5106 **Full Changelog**: fastify/fastify@v4.24.2...v4.24.3 ### [`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2) #### What's Changed - fix: build problems when `Symbol.asyncDispose` type is not available. by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5096 **Full Changelog**: fastify/fastify@v4.24.1...v4.24.2 ### [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) #### What's Changed - fix: citgm by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [fastify/fastify#5075 - fix: HEAD route reseting by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [fastify/fastify#5090 **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 ### [`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0) #### What's Changed - docs: Add blank line before onclose hook heading by [@kadoshita](https://togithub.com/kadoshita) in [fastify/fastify#5042 - build(dependabot): ignore tap major updates by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5047 - chore: Bump actions/checkout from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5048 - chore: more perf by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5016 - docs(ecosystem): add fastify-prisma by [@zrosenbauer](https://togithub.com/zrosenbauer) in [fastify/fastify#5041 - test: fix ci due yup breaking by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5058 - perf: optimize split params by [@Connormiha](https://togithub.com/Connormiha) in [fastify/fastify#5057 - chore: implicitly infer SchemaCompiler as readonly by [@DemonHa](https://togithub.com/DemonHa) in [fastify/fastify#5060 - test(logger): splitting existing tests to avoid pipeline failing for timeout by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5064 - fix(async-hooks): mixing async and callback style in preHandler option now returns an error by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5069 - fix: enhance 100 and 200 or 204 handling by [@Iamshankhadeep](https://togithub.com/Iamshankhadeep) in [fastify/fastify#5056 - docs: add fastify-cloudflare-turnstile to ecosystem by [@112RG](https://togithub.com/112RG) in [fastify/fastify#5067 - docs: Fixing a couple typos by [@Cadienvan](https://togithub.com/Cadienvan) in [fastify/fastify#5079 - feat: Add `Symbol.asyncDispose` to improve DX in short lived servers. by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5082 - docs: Documentation changes requested at [#5082](https://togithub.com/fastify/fastify/issues/5082) by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5083 - docs: remove thenable promisesaplus spec references by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5081 - docs(ecosystem): add fastify-event-bus by [@Shiva127](https://togithub.com/Shiva127) in [fastify/fastify#5085 - docs: update docs for FastifyPlugin by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5070 - docs: Update for .hijack heading by [@jackbatzner](https://togithub.com/jackbatzner) in [fastify/fastify#5088 - fix(warnings): fixed warning when accessing context property from Request and Reply objects by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5084 - fix: HEAD route search by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [fastify/fastify#5078 #### New Contributors - [@kadoshita](https://togithub.com/kadoshita) made their first contribution in [fastify/fastify#5042 - [@Connormiha](https://togithub.com/Connormiha) made their first contribution in [fastify/fastify#5057 - [@DemonHa](https://togithub.com/DemonHa) made their first contribution in [fastify/fastify#5060 - [@Iamshankhadeep](https://togithub.com/Iamshankhadeep) made their first contribution in [fastify/fastify#5056 - [@Cadienvan](https://togithub.com/Cadienvan) made their first contribution in [fastify/fastify#5079 - [@arthurfiorette](https://togithub.com/arthurfiorette) made their first contribution in [fastify/fastify#5082 - [@jackbatzner](https://togithub.com/jackbatzner) made their first contribution in [fastify/fastify#5088 **Full Changelog**: fastify/fastify@v4.23.2...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.23.2` -> `4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>fastify/fastify (fastify)</summary> [`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3) - fix: timeout on citgm tests by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [fastify/fastify#5101 - chore: add missing `use strict` directives by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5106 **Full Changelog**: fastify/fastify@v4.24.2...v4.24.3 [`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2) - fix: build problems when `Symbol.asyncDispose` type is not available. by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5096 **Full Changelog**: fastify/fastify@v4.24.1...v4.24.2 [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) - fix: citgm by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [fastify/fastify#5075 - fix: HEAD route reseting by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [fastify/fastify#5090 **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 [`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0) - docs: Add blank line before onclose hook heading by [@kadoshita](https://togithub.com/kadoshita) in [fastify/fastify#5042 - build(dependabot): ignore tap major updates by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5047 - chore: Bump actions/checkout from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5048 - chore: more perf by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5016 - docs(ecosystem): add fastify-prisma by [@zrosenbauer](https://togithub.com/zrosenbauer) in [fastify/fastify#5041 - test: fix ci due yup breaking by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5058 - perf: optimize split params by [@Connormiha](https://togithub.com/Connormiha) in [fastify/fastify#5057 - chore: implicitly infer SchemaCompiler as readonly by [@DemonHa](https://togithub.com/DemonHa) in [fastify/fastify#5060 - test(logger): splitting existing tests to avoid pipeline failing for timeout by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5064 - fix(async-hooks): mixing async and callback style in preHandler option now returns an error by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5069 - fix: enhance 100 and 200 or 204 handling by [@Iamshankhadeep](https://togithub.com/Iamshankhadeep) in [fastify/fastify#5056 - docs: add fastify-cloudflare-turnstile to ecosystem by [@112RG](https://togithub.com/112RG) in [fastify/fastify#5067 - docs: Fixing a couple typos by [@Cadienvan](https://togithub.com/Cadienvan) in [fastify/fastify#5079 - feat: Add `Symbol.asyncDispose` to improve DX in short lived servers. by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5082 - docs: Documentation changes requested at [#5082](https://togithub.com/fastify/fastify/issues/5082) by [@arthurfiorette](https://togithub.com/arthurfiorette) in [fastify/fastify#5083 - docs: remove thenable promisesaplus spec references by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5081 - docs(ecosystem): add fastify-event-bus by [@Shiva127](https://togithub.com/Shiva127) in [fastify/fastify#5085 - docs: update docs for FastifyPlugin by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5070 - docs: Update for .hijack heading by [@jackbatzner](https://togithub.com/jackbatzner) in [fastify/fastify#5088 - fix(warnings): fixed warning when accessing context property from Request and Reply objects by [@giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [fastify/fastify#5084 - fix: HEAD route search by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [fastify/fastify#5078 - [@kadoshita](https://togithub.com/kadoshita) made their first contribution in [fastify/fastify#5042 - [@Connormiha](https://togithub.com/Connormiha) made their first contribution in [fastify/fastify#5057 - [@DemonHa](https://togithub.com/DemonHa) made their first contribution in [fastify/fastify#5060 - [@Iamshankhadeep](https://togithub.com/Iamshankhadeep) made their first contribution in [fastify/fastify#5056 - [@Cadienvan](https://togithub.com/Cadienvan) made their first contribution in [fastify/fastify#5079 - [@arthurfiorette](https://togithub.com/arthurfiorette) made their first contribution in [fastify/fastify#5082 - [@jackbatzner](https://togithub.com/jackbatzner) made their first contribution in [fastify/fastify#5088 **Full Changelog**: fastify/fastify@v4.23.2...v4.24.0 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: HEAD route reseting

51c2807

climba03003 requested changes Oct 12, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

fix: HEAD route reseting

9629965

mcollina approved these changes Oct 12, 2023

View reviewed changes

ivan-tymoshenko marked this pull request as draft October 12, 2023 10:29

fix: HEAD route reseting

d30c875

ivan-tymoshenko marked this pull request as ready for review October 12, 2023 10:32

climba03003 approved these changes Oct 12, 2023

View reviewed changes

mcollina merged commit 91c7b44 into fastify:main Oct 12, 2023
26 checks passed

arthurfiorette pushed a commit to arthurfiorette/fastify that referenced this pull request Oct 14, 2023

fix: HEAD route reseting (fastify#5090)

23c36ac

renovate bot mentioned this pull request Oct 29, 2023

chore(deps): update all non-major dependencies cyco130/vavite#74

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: HEAD route reseting #5090

fix: HEAD route reseting #5090

ivan-tymoshenko commented Oct 11, 2023

climba03003 Oct 12, 2023 •

edited

climba03003 commented Oct 12, 2023

ivan-tymoshenko commented Oct 12, 2023

This comment was marked as outdated.

ivan-tymoshenko commented Oct 12, 2023 •

edited

ivan-tymoshenko commented Oct 12, 2023

mcollina left a comment

climba03003 left a comment

fix: HEAD route reseting #5090

fix: HEAD route reseting #5090

Conversation

ivan-tymoshenko commented Oct 11, 2023

climba03003 Oct 12, 2023 • edited

Choose a reason for hiding this comment

climba03003 commented Oct 12, 2023

ivan-tymoshenko commented Oct 12, 2023

This comment was marked as outdated.

ivan-tymoshenko commented Oct 12, 2023 • edited

ivan-tymoshenko commented Oct 12, 2023

mcollina left a comment

Choose a reason for hiding this comment

climba03003 left a comment

Choose a reason for hiding this comment

climba03003 Oct 12, 2023 •

edited

ivan-tymoshenko commented Oct 12, 2023 •

edited