Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: citgm #5075

Merged
merged 21 commits into from Oct 12, 2023
Merged

fix: citgm #5075

merged 21 commits into from Oct 12, 2023

Conversation

simone-sanfratello
Copy link
Contributor

@simone-sanfratello simone-sanfratello commented Oct 4, 2023 •
edited

Following nodejs/citgm#973

Tested locally on node 21 nightly

test files:

  • custom-parser.1.test.js
  • listen.test.js
  • plugin.test.js
  • route.test.js
  • stream.test.js

Have been splitted because they contained too many tests, that hit timeout on slow citgm machines

Note before merge:

  • remove debugging console.logs
  • restore npm test as it was
  • make sure citgm script is been used on citgm, must be in lookup.json file or citgm settings

Note to future me: run it as citgm git+https://github.com/simone-sanfratello/fastify#fix/citgm -l lookup.json

lookup.json

{
  "useGitClone": true,
  "scripts": ["citgm"]
}

@simone-sanfratello simone-sanfratello changed the title wip: fix citgm fix: citgm (wip) Oct 4, 2023
simone-sanfratello
simone-sanfratello commented Oct 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@mcollina mcollina changed the title fix: citgm (wip) fix: citgm Oct 12, 2023
mcollina
mcollina approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

package.json Outdated Show resolved Hide resolved
@mcollina mcollina marked this pull request as ready for review October 12, 2023 10:20
@mcollina
Copy link
Member

We have citgm passing now with this PR.

@mcollina mcollina merged commit 04cc8c1 into fastify:main Oct 12, 2023
27 checks passed
@Eomm Eomm added the test Issue or pr related to our testing infrastructure. label Oct 12, 2023
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Oct 13, 2023
@renovate
chore(deps): update dependency fastify to v4.24.1 (#323)
ca0d3c9 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.24.0` ->
`4.24.1`](https://renovatebot.com/diffs/npm/fastify/4.24.0/4.24.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1)

#### What's Changed

- fix: citgm by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[fastify/fastify#5075
- fix: HEAD route reseting by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[fastify/fastify#5090

**Full Changelog**:
fastify/fastify@v4.24.0...v4.24.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
arthurfiorette pushed a commit to arthurfiorette/fastify that referenced this pull request Oct 14, 2023
@simone-sanfratello @arthurfiorette
fix: citgm (fastify#5075)
d35ed61
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Nov 15, 2023
@renovate
fix(deps): update dependency fastify to v4.24.3 (#9457)
0510002 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.2` ->
`4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3)

#### What's Changed

- fix: timeout on citgm tests by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[fastify/fastify#5101
- chore: add missing `use strict` directives by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5106

**Full Changelog**:
fastify/fastify@v4.24.2...v4.24.3

###
[`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2)

#### What's Changed

- fix: build problems when `Symbol.asyncDispose` type is not available.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5096

**Full Changelog**:
fastify/fastify@v4.24.1...v4.24.2

###
[`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1)

#### What's Changed

- fix: citgm by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[fastify/fastify#5075
- fix: HEAD route reseting by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[fastify/fastify#5090

**Full Changelog**:
fastify/fastify@v4.24.0...v4.24.1

###
[`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0)

#### What's Changed

- docs: Add blank line before onclose hook heading by
[@&#8203;kadoshita](https://togithub.com/kadoshita) in
[fastify/fastify#5042
- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5047
- chore: Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5048
- chore: more perf by [@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5016
- docs(ecosystem): add fastify-prisma by
[@&#8203;zrosenbauer](https://togithub.com/zrosenbauer) in
[fastify/fastify#5041
- test: fix ci due yup breaking by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5058
- perf: optimize split params by
[@&#8203;Connormiha](https://togithub.com/Connormiha) in
[fastify/fastify#5057
- chore: implicitly infer SchemaCompiler as readonly by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[fastify/fastify#5060
- test(logger): splitting existing tests to avoid pipeline failing for
timeout by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5064
- fix(async-hooks): mixing async and callback style in preHandler option
now returns an error by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5069
- fix: enhance 100 and 200 or 204 handling by
[@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) in
[fastify/fastify#5056
- docs: add fastify-cloudflare-turnstile to ecosystem by
[@&#8203;112RG](https://togithub.com/112RG) in
[fastify/fastify#5067
- docs: Fixing a couple typos by
[@&#8203;Cadienvan](https://togithub.com/Cadienvan) in
[fastify/fastify#5079
- feat: Add `Symbol.asyncDispose` to improve DX in short lived servers.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5082
- docs: Documentation changes requested at
[#&#8203;5082](https://togithub.com/fastify/fastify/issues/5082) by
[@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5083
- docs: remove thenable promisesaplus spec references by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5081
- docs(ecosystem): add fastify-event-bus by
[@&#8203;Shiva127](https://togithub.com/Shiva127) in
[fastify/fastify#5085
- docs: update docs for FastifyPlugin by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5070
- docs: Update for .hijack heading by
[@&#8203;jackbatzner](https://togithub.com/jackbatzner) in
[fastify/fastify#5088
- fix(warnings): fixed warning when accessing context property from
Request and Reply objects by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5084
- fix: HEAD route search by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[fastify/fastify#5078

#### New Contributors

- [@&#8203;kadoshita](https://togithub.com/kadoshita) made their first
contribution in
[fastify/fastify#5042
- [@&#8203;Connormiha](https://togithub.com/Connormiha) made their first
contribution in
[fastify/fastify#5057
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[fastify/fastify#5060
- [@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) made
their first contribution in
[fastify/fastify#5056
- [@&#8203;Cadienvan](https://togithub.com/Cadienvan) made their first
contribution in
[fastify/fastify#5079
- [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) made
their first contribution in
[fastify/fastify#5082
- [@&#8203;jackbatzner](https://togithub.com/jackbatzner) made their
first contribution in
[fastify/fastify#5088

**Full Changelog**:
fastify/fastify@v4.23.2...v4.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Nov 16, 2023
@renovate @jtoar
fix(deps): update dependency fastify to v4.24.3 (#9457)
d811da3 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.2` ->
`4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

<details>
<summary>fastify/fastify (fastify)</summary>

[`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3)

- fix: timeout on citgm tests by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[fastify/fastify#5101
- chore: add missing `use strict` directives by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5106

**Full Changelog**:
fastify/fastify@v4.24.2...v4.24.3

[`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2)

- fix: build problems when `Symbol.asyncDispose` type is not available.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5096

**Full Changelog**:
fastify/fastify@v4.24.1...v4.24.2

[`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1)

- fix: citgm by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[fastify/fastify#5075
- fix: HEAD route reseting by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[fastify/fastify#5090

**Full Changelog**:
fastify/fastify@v4.24.0...v4.24.1

[`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0)

- docs: Add blank line before onclose hook heading by
[@&#8203;kadoshita](https://togithub.com/kadoshita) in
[fastify/fastify#5042
- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5047
- chore: Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5048
- chore: more perf by [@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5016
- docs(ecosystem): add fastify-prisma by
[@&#8203;zrosenbauer](https://togithub.com/zrosenbauer) in
[fastify/fastify#5041
- test: fix ci due yup breaking by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5058
- perf: optimize split params by
[@&#8203;Connormiha](https://togithub.com/Connormiha) in
[fastify/fastify#5057
- chore: implicitly infer SchemaCompiler as readonly by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[fastify/fastify#5060
- test(logger): splitting existing tests to avoid pipeline failing for
timeout by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5064
- fix(async-hooks): mixing async and callback style in preHandler option
now returns an error by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5069
- fix: enhance 100 and 200 or 204 handling by
[@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) in
[fastify/fastify#5056
- docs: add fastify-cloudflare-turnstile to ecosystem by
[@&#8203;112RG](https://togithub.com/112RG) in
[fastify/fastify#5067
- docs: Fixing a couple typos by
[@&#8203;Cadienvan](https://togithub.com/Cadienvan) in
[fastify/fastify#5079
- feat: Add `Symbol.asyncDispose` to improve DX in short lived servers.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5082
- docs: Documentation changes requested at
[#&#8203;5082](https://togithub.com/fastify/fastify/issues/5082) by
[@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[fastify/fastify#5083
- docs: remove thenable promisesaplus spec references by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5081
- docs(ecosystem): add fastify-event-bus by
[@&#8203;Shiva127](https://togithub.com/Shiva127) in
[fastify/fastify#5085
- docs: update docs for FastifyPlugin by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5070
- docs: Update for .hijack heading by
[@&#8203;jackbatzner](https://togithub.com/jackbatzner) in
[fastify/fastify#5088
- fix(warnings): fixed warning when accessing context property from
Request and Reply objects by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[fastify/fastify#5084
- fix: HEAD route search by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[fastify/fastify#5078

- [@&#8203;kadoshita](https://togithub.com/kadoshita) made their first
contribution in
[fastify/fastify#5042
- [@&#8203;Connormiha](https://togithub.com/Connormiha) made their first
contribution in
[fastify/fastify#5057
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[fastify/fastify#5060
- [@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) made
their first contribution in
[fastify/fastify#5056
- [@&#8203;Cadienvan](https://togithub.com/Cadienvan) made their first
contribution in
[fastify/fastify#5079
- [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) made
their first contribution in
[fastify/fastify#5082
- [@&#8203;jackbatzner](https://togithub.com/jackbatzner) made their
first contribution in
[fastify/fastify#5088

**Full Changelog**:
fastify/fastify@v4.23.2...v4.24.0

</details>

---

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simone-sanfratello @mcollina @Eomm