Skip to content

Commit

Permalink
Fix Android build sequencing
Browse files Browse the repository at this point in the history
Summary:
The native libraries are compiled outside of the usual Android build flow using separate CLI task. Because of that, shared native libraries may not exist when AAR is bundled, resulting in weird sequencing issues.

This change updates gradle dependency graph, executing RN native build before Android part (as it is done in RNTester already).

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D29209249

fbshipit-source-id: 36386c78996b1cd9b1731735e36e571199e9e81b
  • Loading branch information
Andrei Shikov authored and kelset committed Jun 18, 2021
1 parent ba4424f commit 121a6a4
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions ReactAndroid/build.gradle
Expand Up @@ -416,11 +416,7 @@ android {
}
}

tasks.withType(JavaCompile) {
compileTask ->
compileTask.dependsOn(packageReactNdkLibs)
}

preBuild.dependsOn(packageReactNdkLibs)
clean.dependsOn(cleanReactNdkLib)

lintOptions {
Expand Down

0 comments on commit 121a6a4

Please sign in to comment.