Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify usage of elementType (Closes #334) #335

Merged
merged 1 commit into from Feb 9, 2021
Merged

Clarify usage of elementType (Closes #334) #335

merged 1 commit into from Feb 9, 2021

Conversation

gbroques
Copy link
Contributor

@gbroques gbroques commented Feb 9, 2021 •
edited

See #334 for context and motivation.

@facebook-github-bot
Copy link

Hi @gbroques!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@gbroques gbroques force-pushed the clarify-usage-of-element-type branch from 56d0d42 to 06f44c7 Compare February 9, 2021 20:16
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ljharb
ljharb approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb force-pushed the clarify-usage-of-element-type branch from 06f44c7 to d62a775 Compare February 9, 2021 20:59
@ljharb ljharb merged commit d62a775 into facebook:master Feb 9, 2021
@gbroques gbroques deleted the clarify-usage-of-element-type branch February 9, 2021 21:16
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gbroques @facebook-github-bot @ljharb