Merge pull request #1297 from alubbe/fix-build-size

Do not include IE11 fix by default, let the users import it when needed
exceljs · May 26, 2020 · 7c3fd11 · 7c3fd11
2 parents 43ee02a + 38e45e8
commit 7c3fd11
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -212,6 +212,7 @@ const ExcelJS = require('exceljs/dist/es5');
 ```javascript
 // polyfills required by exceljs
 require('core-js/modules/es.promise');
+require('core-js/modules/es.string.includes');
 require('core-js/modules/es.object.assign');
 require('core-js/modules/es.object.keys');
 require('regenerator-runtime/runtime');

diff --git a/README_zh.md b/README_zh.md
@@ -190,6 +190,7 @@ const ExcelJS = require('exceljs/dist/es5');
 ```javascript
 // exceljs 所需的 polyfills
 require('core-js/modules/es.promise');
+require('core-js/modules/es.string.includes');
 require('core-js/modules/es.object.assign');
 require('core-js/modules/es.object.keys');
 require('regenerator-runtime/runtime');

diff --git a/lib/exceljs.browser.js b/lib/exceljs.browser.js
@@ -1,26 +1,9 @@
 /* eslint-disable import/no-extraneous-dependencies,node/no-unpublished-require */
 require('core-js/modules/es.promise');
-require('core-js/modules/es.string.includes');
 require('core-js/modules/es.object.assign');
 require('core-js/modules/es.object.keys');
 require('regenerator-runtime/runtime');
 
-const rewritePattern = require('regexpu-core');
-const {generateRegexpuOptions} = require('@babel/helper-create-regexp-features-plugin/lib/util');
-
-const {RegExp} = global;
-try {
-  RegExp('a', 'u');
-} catch (err) {
-  global.RegExp = function(pattern, flags) {
-    if (flags && flags.includes('u')) {
-      return new RegExp(rewritePattern(pattern, flags, generateRegexpuOptions({flags, pattern})));
-    }
-    return new RegExp(pattern, flags);
-  };
-  global.RegExp.prototype = RegExp;
-}
-
 const ExcelJS = {
   Workbook: require('./doc/workbook'),
 };

diff --git a/package.json b/package.json
@@ -107,7 +107,6 @@
   "devDependencies": {
     "@babel/cli": "^7.6.4",
     "@babel/core": "^7.9.0",
-    "@babel/helper-create-regexp-features-plugin": "^7.8.8",
     "@babel/preset-env": "^7.9.5",
     "@types/chai": "^4.2.11",
     "@types/mocha": "^7.0.2",
@@ -141,7 +140,6 @@
     "prettier-eslint": "^9.0.0",
     "prettier-eslint-cli": "^5.0.0",
     "regenerator-runtime": "^0.13.5",
-    "regexpu-core": "^4.7.0",
     "ts-node": "^8.9.0",
     "typescript": "^3.8.3"
   }