TransactionResponse type is wrong for wait

[roderik]

    const block = await provider.getBlockWithTransactions(blockNumber);
    for (const transaction of block.transactions) {
       await transaction.wait(2)
    }

==> TypeError: transaction.wait is not a function

The type of TransationResponse is

export interface TransactionResponse extends Transaction {
    hash: string;
    blockNumber?: number;
    blockHash?: string;
    timestamp?: number;
    confirmations: number;
    from: string;
    raw?: string;
    wait: (confirmations?: number) => Promise<TransactionReceipt>;
}

I think it needs to be

export interface TransactionResponse extends Transaction {
    hash: string;
    blockNumber?: number;
    blockHash?: string;
    timestamp?: number;
    confirmations: number;
    from: string;
    raw?: string;
    wait?: (confirmations?: number) => Promise<TransactionReceipt>;
}

Or there need to be two types, one for getBlockWithTransactions and one for send

FYI, the use case is an indexer, so I need for each block the tx + receipt, the wait function with 1 or 0 as confirmations seemed like an elegant solution which would allow me not to pass around the provider.

[ricmoo]

You are probably right that I am not adding it in that case. Surprised TypeScript didn’t complain.

I will add a .wait to those objects. :)

[zemse]

Yesterday I was seeing a similar problem here:

providerETH.on(filter, async (log: ethers.Event) => {
  const tx = await event.getTransaction(); // this throws getTransaction is not a function
});

(await plasmaManagerInstanceETH.queryFilter(
  filter,
  6889863,
  'latest'
)).forEach(event => {
   const tx = await event.getTransaction(); // this works
});

[kimxilxyong]

I have "wait is not a function", i'm using it as per v5 migration examples. I really would like to use ethers instead of web3 because of the much cleaner architecture, but the need to get informed about the confirmed blocks is fundamental.
Has there been any progress? Should i try directly from the git?

const txResponse = await contract.Donation(donorName, { value: wei, });
const txReceipt = await txResponse.wait(24);      // this throws wait is not a function

[ricmoo]

@zemse I think you meant log instead of event in your callback (looks like you copy-pasted, but changed the signature ;))

providerETH.on(filter, async (log: ethers.Event) => {
  //               v----- here
  const tx = await event.getTransaction(); // this throws getTransaction is not a function
});

[ricmoo]

@kimxilxyong Can you add a console.log(txResponse) before the .wait line to see what was returned? If it was marked as "pure" or "view" in the ABI, it may be returning a value from the contract as a eth_call result rather than a send transaction... Just a thought. Let me know what the console.log returns. :)

[zemse]

I think I made an error while copy pasting that time. Redoing it right now in browser and adding some screenshots

providerESN.on(dayswappersInstanceESN.filters.Authorised(), console.log)

After that I made a transaction that emits the above event. Then got this console log.

With queryfilter

The query filter one is definitely filled up with methods. Maybe my mistake is that the typing in async (log: ethers.Event) => { was an incorrect assumption. What type should I have put there? This is because I have developed a habit to continuously provide typescript enough info (prevent anys) so that it finds things I do wrong when I'm not in full senses.

Maybe we can do some typescript overloading if possible, so that whatever type is there (in case of pending, block and other ons), it comes implicit. Would you like if I try this and PR?

[roderik]

@zemse console.log at runtime does not check anything typescript related. If you trick typescript to believe the object is an Event, then that only affects the compiler. If you would do ('some string' as any) as Event your IDE/compiler would believe it was an Event, but console.log would still return 'some string'

[ricmoo]

This has been fixed in 5.4.2. Try it out and let me know if you still have any problems.

[ricmoo]

Closing now, but let me know if you continue to have issues.

Thanks! :)