Experimental/EIP1193Bridge: fix getCode call
#3166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
bug
ricmoo
added a commit
that referenced
this pull request
Jul 14, 2022
ricmoo
added
the
fixed/complete
|
Hey @ricmoo, thanks for fixing this. I assume I can close this PR then? And do you have any rough estimation of when 5.7 will be released? |
|
You can keep it open. I’ll close it once I publish the v5.7.0 release. :) |
|
This has been fixed in v5.7.0. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes relaying
eth_getCodecall toprovider.getBlockby relaying it toprovider.getCode.The PR includes many changes for
package-lock.jsonbecause my npm complained about the outdated lockfile format and wanted to regenerate it completely. I'm on npm8.13.2, which is the latest version. I can revert this change if needed.