console.log in library code when parsing transaction

[ouromoros]

Ethers Version

5.6.2

Search Terms

console.log parse transaction

Describe the Problem

There are a couple of lines of console.log() in transaction code. They can't be disabled and can pollute program output.

Since it seems that we do have an internal logger, maybe it's better to use that instead?

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response

[ricmoo]

I'm not exactly sue what the correct thing to do in this case should be, as that indicates that the parsed transaction issuing EIP-155, but has a v that is out of the valid size range for JavaScript numbers, so other things might go awry.

I think in this case, for now, it will just leave the v undefined and return an unsigned transaction.

The API has been overhauled in v6, so that large chain ID support is built in, but I don't think there is a good way to shoehorn it into v5, so this is likely as best we can do for now.

And of course, the console.log should be removed. :)

[ricmoo]

This has been addressed in 5.6.7.

Thanks! :)