Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the pocket-provider to align with more recent updates #2980

Closed
wants to merge 1 commit into from

Conversation

blockjoe
Copy link

@blockjoe blockjoe commented May 12, 2022

While the original pocket provider provided some really great work-arounds to how the Pocket Portal handled it's RPC service, a lot of those unique quirks have since changed, and pocket now provides a more consistent experience.

The big changes to how the Pocket Portal manages it's RPC are as follows:

  1. Different networks can all now use the same API key and Secret Key, no need for separate keys for each network.
  2. All endpoints are now load balanced, this is no longer conditional on the specific network.

Since the last update, Pocket Network now supports the following ethers.js supported networks:

  • Kovan
  • Gnosis (xDAI)
  • Polygon (Matic)
  • Binance Smart Chain (bnb)

As well as now supporting the following other likely future compatible networks:

  • Avalanche
  • DFKchain
  • Fantom
  • FUSE
  • Harmony
  • IoTeX
  • OKExChain
  • Solana

These will always be tracked live here.

Additionally, Pocket Network provides public community RPC resources available for the following supported chains:

As well as the following unsupported chains:

All of which will be available here

I'm not sure if these above links constitute a community resource by the ethers definition, but unfortunately, the current means of identifying them is rather hodge-podge at the moment. I've currently left the isCommunityResource() method as false, but am happy to go back and figure out the logic for determining that if the above public RPCs do qualify as a community resource.

@ricmoo
Copy link
Member

ricmoo commented May 12, 2022

Thanks! I'll look into this shortly. :)

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label May 12, 2022
@blockjoe
Copy link
Author

blockjoe commented Jun 8, 2022

Hey, feel free to let me know if there's anything on my end I can do to help validate this for you. Happy to push through the proper isCommunityResource() method if it is the case that public RPCs count as community resources, and run any tests against the implementation that you would need.

@ricmoo ricmoo added the minor-bump Planned for the next minor version bump. label Jun 29, 2022
@ricmoo
Copy link
Member

ricmoo commented Jul 27, 2022

@blockjoe Heya! Can you e-mail me@ricmoo.com when you get a chance? I haven't been able to get ahold of my regular contact at Pocket and have some issues with getting this PR sorted...

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed minor-bump Planned for the next minor version bump. labels Aug 19, 2022
@ricmoo
Copy link
Member

ricmoo commented Aug 19, 2022

This has been updated in v5.7.0.

Thanks! :)

@ricmoo ricmoo closed this Aug 19, 2022
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Feb 23, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants