Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logger.checkNew #2861

Closed
ricmoo opened this issue Apr 5, 2022 · 2 comments
Closed

Remove logger.checkNew #2861

ricmoo opened this issue Apr 5, 2022 · 2 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Apr 5, 2022

Describe the Feature

The use of the logger.checkNew in classes prevents users from accidentally using a class as a function and prevents “old-school” coding styles which have magic constructors from going unnoticed, but modern developers seldom use this style.

The run-time logger.checkNew also prevents certain transpiler configurations from working with TypeScript (and presumably Babel), so it makes sense to remove these checks.

Code Example

No response
@ricmoo ricmoo added the enhancement New feature or improvement. label Apr 5, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Apr 5, 2022

See #2860.

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label May 2, 2022
ricmoo added a commit that referenced this issue May 12, 2022
@ricmoo
Remove pedantic check for new keyword which broke some platforms for …
32b7373 
…inheritance (#2860, #2861).
@ricmoo
Copy link
Member Author

ricmoo commented May 14, 2022

This has been fixed in 5.6.6. Let me know if you still have any issues.

Thanks! :)

@ricmoo ricmoo closed this as completed May 14, 2022
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 14, 2022
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Remove pedantic check for new keyword which broke some platforms for …
c6db1ca 
…inheritance (ethers-io#2860, ethers-io#2861).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo