Issue Inheriting Ethers Wallet Class

[jettblu]

Hello, hope you're doing well. I'm building a general purpose wallet that inherits from Ethers, but I am receiving the following strange error when I run the compiled package (local jest tests work fine):

Wallet cannot be invoked without 'new'

which points towards this line in the call to super():
__this = Wallet.call(this, privateKey, provider) || this;

Do you have any idea what may be causing this issue? I have attached the constructor for my wallet class below:

constructor(privateKey: BytesLike | ExternallyOwnedAccount | SigningKey, network?:Network, provider?: Provider) {
    super(privateKey, provider);

    if(network==null){
        network = defaultNetworks.eth
    }
    let chainId = network.chainId;
    // if chainId is provided... set as wallet coin type
    if(chainId!=null){
        this.chainId = chainId
    }
    this.networkFamily = network.networkFamily;
    // sets address for wallet
    this.generateAddress(this.publicKey, this.privateKey)
}

[ricmoo]

Interesting consequence of a check ethers performs, which is to ensure new is used for every object. This is to prevent people from attempting to use a class as a function.

It looks like your code is being transpired into a very old format of JavaScript which is replacing the super call with a normal .call to the super class. Can you configure your transputer to use the standard super notation?

[jettblu]

After a bit of searching it appears as if there may be an issue trying to call super on classes that were compiled with es2015, as Ethers is. Do you know of a way to resolve this?

[ricmoo]

I was just looking at your tsconfig and thinking it looked fine, and poking around stackexchange. :)

Hmm... I unfortunately don't know of any solution to that. I'm working on v6 right now and because of this plan to remove the checkNew in the classes. But for v5, not sure of a good solution. Can you try setting your target as es2015? Or do you need es2017 features?

[jettblu]

Gotcha'! Thanks for investigating. I am going to try forking ethers to remove checknew for the wallet class, as I need to use es2017. Looking forward to V6!

[ricmoo]

See #2861 to track removing checkNew usage. :)

[ricmoo]

The issue has been resolved, see #2861 for details (commits, etc).

Thanks! :)