Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ENS's getContentHash for skylinks #2853

Closed
dghelm opened this issue Mar 30, 2022 · 1 comment
Closed

Add support to ENS's getContentHash for skylinks #2853

dghelm opened this issue Mar 30, 2022 · 1 comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@dghelm
Copy link

dghelm commented Mar 30, 2022

Describe the Feature

The ENS protocol and official frontend support setting a content hash for sia:// URIs, which are used to resolve content on the Skynet decentralized storage network.

The ETH,LIMO team requested this integration while building support for Skynet into their resolver. Loading webapps hosted on Skynet via ENS is already supported by Metamask's browser extension and Cloudflare's eth.link, and we'd love to see further adoption of decentralized storage standards.

The Skynet Labs team would be happy to make a PR, as we have experience dealing with the multi-codec and skylink formats.

Code Example

// for skynet-ens.eth

await resolver.getContentHash();
// 'sia://AQCRuTdTPzCyyU6I82eV7VDFVLPW82LJS9mH-chmjDlKUQ'
@dghelm dghelm added the enhancement New feature or improvement. label Mar 30, 2022
@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label May 11, 2022
ricmoo added a commit that referenced this issue May 20, 2022
@ricmoo
Copy link
Member

ricmoo commented May 21, 2022

This is now available in 5.6.7. Try it out and let me know if you have any problems. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 21, 2022
@ricmoo ricmoo closed this as completed May 26, 2022
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants