New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rise in ethereum difficulty will break block.difficulty #2001
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
minor-bump
Planned for the next minor version bump.
Comments
I completely agree. I will schedule this change for the next major-version. Thanks! :) |
ricmoo
added
major-bump
Planned for the next major version bump
on-deck
This Enhancement or Bug is currently being worked on.
labels
Sep 3, 2021
ricmoo
added
enhancement
New feature or improvement.
minor-bump
Planned for the next minor version bump.
and removed
major-bump
Planned for the next major version bump
labels
Sep 13, 2021
I'll add this as the next minor bump as discussed in #2036, for v5 and in v6 this will be a BigNumber and the new |
ricmoo
added a commit
that referenced
this issue
Oct 16, 2021
I've dded the Thanks! :) |
ricmoo
added
fixed/complete
This Bug is fixed or Enhancement is complete and published.
and removed
on-deck
This Enhancement or Bug is currently being worked on.
labels
Oct 20, 2021
Thanks! I'll upgrade and try it out! |
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or improvement.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
minor-bump
Planned for the next minor version bump.
The following code tries to fit
block.difficulty
into a number.ethers.js/packages/providers/src.ts/formatter.ts
Lines 274 to 285 in f0b3bc3
The difficulty in the recent Ethereum blocks is fast approaching
Number.MAX_SAFE_INTEGER
. Comparing:In order to properly handle this the type of
block.difficulty
would need to change toBigNumber
. Since this is a breaking change I am not sure what the process for it should be.The text was updated successfully, but these errors were encountered: