Fix: include loadRules in internalSlotsMap cache

[henryqdineen]

This fixes a possible bug that I ran into with eslint@7.13.0. When using the rulesPath option of the ESLint() constructor it would run into this error

TypeError: loadRules is not a function

I tracked this down to the implementation of clearCache(). When createBaseConfigArray() is called it won't supply the loadRules property because it doesn't exist in the internalSlotsMap value.

eslintrc/lib/cascading-config-array-factory.js

Lines 322 to 324 in 8b202ff

	const slots = internalSlotsMap.get(this);
	slots.baseConfigArray = createBaseConfigArray(slots);

This causes the loadRules is not a function on this line:

eslintrc/lib/cascading-config-array-factory.js

Line 129 in 8b202ff

loadRules(rulesPath, cwd)

Thanks!

[nzakas]

Thanks, that definitely looks like a bug. Can you add a test to verify the fix?

[henryqdineen]

I'm a little overwhelmed looking at the tests/lib/cascading-config-array-factory.js file. Do you have any advice for what kind of test I should add?

[nzakas]

I think you should be able to do a fairly simple test where you create a new instance of CascadingConfigArrayFactory and pass in a rulePaths argument. I think that will trigger the error without needing to do anything else. You can just throw the test in a describe at the bottom of the file for "bug fixes".

[nzakas]

LGTM. Thanks!

[mdjermanovic]

LGTM, thanks!