Skip to content

Commit

Permalink
Linux/ia32 warning moved from Packager to @electron/get (#1016)
Browse files Browse the repository at this point in the history
  • Loading branch information
malept committed Jun 20, 2019
1 parent 67e3021 commit f8a3cac
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -17,7 +17,7 @@
},
"homepage": "https://github.com/electron-userland/electron-packager",
"dependencies": {
"@electron/get": "^1.2.0",
"@electron/get": "^1.3.0",
"asar": "^2.0.1",
"cross-zip": "^2.1.5",
"debug": "^4.0.1",
Expand Down
1 change: 0 additions & 1 deletion src/targets.js
Expand Up @@ -15,7 +15,6 @@ const officialPlatformArchCombos = {

const linuxArchBuildVersions = {
arm64: '>= 1.8.0',
ia32: '< 4.0.0-beta.1',
mips64el: '^1.8.2-beta.5'
}

Expand Down
7 changes: 0 additions & 7 deletions test/targets.js
Expand Up @@ -53,13 +53,6 @@ test('allOfficialArchsForPlatformAndVersion returns mips64el when the correct ve
'should not be found when version is < 1.8.2-beta.5')
})

test('allOfficialArchsForPlatformAndVersion returns ia32 when the correct version is specified', t => {
t.true(targets.allOfficialArchsForPlatformAndVersion('linux', '2.0.0').includes('ia32'),
'should be found when version is < 4.0.0')
t.false(targets.allOfficialArchsForPlatformAndVersion('linux', '4.0.0').includes('ia32'),
'should not be found when version is >= 4.0.0-beta.1')
})

test('validateListFromOptions does not take non-Array/String values', t => {
targets.supported.digits = new Set(['64', '65'])
t.false(targets.validateListFromOptions({ digits: 64 }, 'digits') instanceof Array,
Expand Down

0 comments on commit f8a3cac

Please sign in to comment.